-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reader mode #7196
Comments
To my understanding, all reader mode does is throw everything except away, using "mostly its own CSS" that you get zero control over because if you did you could sneak all sorts of things back in with crafty before/after code (edited). Looking at the site in FF on desktop I get all the content when entering reader mode, which platform and browser does the content go missing for? |
I got this on my iPhone within Twitter (clicking on the link in Twitter opens the link within Twitter in Reader View). I don't really know how to test it more broadly. |
I may have to hand this over to whomever has an iPhone =S |
@danielfmiranda let me know if I can help with anything! |
Hi Everyone! Here are my findings regarding this issue:
After some more investigation, it appears that each browser implements its own algorithm for generating reader views (link to mozillas) If your page does not score high enough in this, the reader view button wont display at all. Which makes sense knowing that the content is rendering correctly on Firefox but not safari-based browsers. From what I have read and tested, it looks as if firefox reader mode is rendering any P element on the page, where Safari is instead looking for P elements that are grouped together under items like headings, etc. Below is a screenshot of the youtube-regrets code with some extra elements that I have added outlined in red: Here it is rendered in Safari Reader Mode: We can see that the items #1 and #2 are being rendered, however the 3rd and 4th elements are being skipped, I am assuming since they are not wrapped in a outer div with other elements like headings and such. Taking a look at the youtube-regrets code, it seems like the items that are not being rendered are usually wrapped in multiple divs for bootstrap formatting, and then finally rendering a singular P tag. My question for @benhohner @Pomax would be, should I create a follow up ticket for refactoring the code to work with safari reader mode? Or just wrap up this ticket? Thanks! Links to items I read for those interested: |
@kristinashu doesn't seem like the solution for this issue would make sense for the audience size of this problem. I think we should close this issue as it would take a large amount of resources to solve. |
Spoke to Kristina and am closing the issue! |
I noticed that reader mode for https://foundation.mozilla.org/en/campaigns/regrets-reporter/findings/ only shows the Intro text and the end Recommendations but is missing most of the content.
Screen cap from prod:
The text was updated successfully, but these errors were encountered: