Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review apps and dev/stage/prod do not build the mozfest site in the same way #5674

Closed
Pomax opened this issue Nov 19, 2020 · 8 comments · Fixed by #5733
Closed

Review apps and dev/stage/prod do not build the mozfest site in the same way #5674

Pomax opened this issue Nov 19, 2020 · 8 comments · Fixed by #5733
Assignees
Milestone

Comments

@Pomax
Copy link
Contributor

Pomax commented Nov 19, 2020

  • dev/stage/prod create mozfest as a top level site, a sibling to the foundation homepage.
  • Review apps create mozfest as a child of the main site homepage.

This causes problems when we need to test backend changes that affect mozfest, as we need to know whether things work with the mozfest page being a true site root. Most importantly, moving the mozfest page to be a top level page and then updating the sites setting to make the mozfest page the default site landing page causes the review app to crash.

We need to fix this so that review apps build the same tree structure as local dev/stage/prod, even if that means we still need to go in and manually "undefault" the homepage site, then mark the mozfest site as default

@Pomax
Copy link
Contributor Author

Pomax commented Dec 7, 2020

This is still not building two sites, once for homepage, and one for mozfest, the same way local dev works.

@Pomax Pomax reopened this Dec 7, 2020
@Pomax
Copy link
Contributor Author

Pomax commented Dec 7, 2020

Right now the way to make this at least work is to:

  1. go into sites and change the page from Homepage to MozFest
  2. save the site update
  3. in heroku, restart the review app dyno

screenshot 669

Once restarted, the review app will now be a normal mozfest app.

@jamilasnell jamilasnell modified the milestones: Dec 7, Dec 21 Dec 8, 2020
@KalobTaulien
Copy link
Contributor

There's currently no way to build two sites on a single Heroku instance. Typically we use another hostname or port, but we're only given the one review app hostname and heroku doesn't allow for additional ports.

@Pomax What are you thinking for next steps? Bring in Tom to check this out?

@jamilasnell jamilasnell modified the milestones: Dec 21, Jan 18 Jan 5, 2021
@jamilasnell
Copy link

Hey @tomusher, Happy New Year! Would you be willing to help out with this issue? It deals with Heroku and there are some elements that Kalob and Pomax need assistance with.

Thank you in advance!

@tomusher
Copy link
Contributor

If I'm reading this correctly, this covers the same ground as #5736 (comment). Do any of the options there sound like they'd help with this @Pomax @KalobTaulien?

@KalobTaulien
Copy link
Contributor

Hey @tomusher

Personally, I like option #2, but you're right it's more complicated — also more future proof. In my opinion, if we're going to do something we might as well do it right. But I won't speak on behalf of Mozilla — @Pomax what do you think about option 2 from this comment?

We also briefly spoke about looking for a tag in the branch that's deploying the review app. So if we tag a branch with "mozfest" it could change the site to be a mozfest site. Frankly I dont know enough about devops to tell if this is doable or not.

@Pomax
Copy link
Contributor Author

Pomax commented Jan 13, 2021

yeah #2 is definitely the way to go

@Pomax
Copy link
Contributor Author

Pomax commented Jan 13, 2021

Also, let me close this issue in favour of #5736 so there's one place for the discussion around this =)

@Pomax Pomax closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants