Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buyers Guide QA: P2 product detail page #2016

Closed
2 tasks
kristinashu opened this issue Oct 23, 2018 · 5 comments
Closed
2 tasks

Buyers Guide QA: P2 product detail page #2016

kristinashu opened this issue Oct 23, 2018 · 5 comments
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@kristinashu
Copy link

kristinashu commented Oct 23, 2018

Follow up from #1860 and #1892
Comps https://redpen.io/p/qz6bdb2811e058ffb1

Intro

Criteria

image

  • improve styling of icons (camera, mic, location, phone, email, twitter) at medium and narrow layouts
    • phone icon disappears
    • list should stack and go into mobile view layout sooner
    • icon centering and spacing is off
    • (or just hid icons at narrower widths)

Updates

image

@kristinashu kristinashu added quality test engineering buyer's guide 🛍 Issues related to the buyer's guide labels Oct 23, 2018
@Pomax
Copy link
Contributor

Pomax commented Oct 24, 2018

I don't see anything in the comp about the accordions (there is no comp with an expanded accordion?), do you mean that the help text that is revealed should be in italics, at 14px size, or something else?

@Pomax
Copy link
Contributor

Pomax commented Oct 24, 2018

Should the dot pattern be "starting at updates all the way to the footer" or "updates only,not related products"?

@Pomax
Copy link
Contributor

Pomax commented Oct 24, 2018

Also, inconveniently I do not have an iphone, I don't quite know how to test the "copy link" function... =S

@kristinashu
Copy link
Author

I don't see anything in the comp about the accordions (there is no comp with an expanded accordion?), do you mean that the help text that is revealed should be in italics, at 14px size, or something else?

Sorry, old link. Here's a mockup:
image

Should the dot pattern be "starting at updates all the way to the footer" or "updates only,not related products"?

Pattern is for "updates" only. I have the height for the pattern at 228px in height. It is only visible if there are updates in that section.

image

Also, inconveniently I do not have an iphone, I don't quite know how to test the "copy link" function... =S

We can file this as a separate ticket. Does it work ok on your phone?

@kristinashu
Copy link
Author

Opened all of these as individual tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
Development

No branches or pull requests

2 participants