Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hardcoded URL on RSS feed #11830

Closed
jhonatan-lopes opened this issue Feb 6, 2024 · 1 comment
Closed

Clean up hardcoded URL on RSS feed #11830

jhonatan-lopes opened this issue Feb 6, 2024 · 1 comment
Labels
code cleanup engineering needs grooming p2 this works should get done when all p1 have been resolved

Comments

@jhonatan-lopes
Copy link
Contributor

jhonatan-lopes commented Feb 6, 2024

The RSS feed is defining the link and feed_url URLs hardcoded to the https://foundation.mozilla.rog/ site. This is a bad practice. We should aim to provide relative urls within the codebase:

class RSSFeed(Feed):
    """
    Blog page RSS feed, using the content:encoded serializer above
    """

    title = "Mozilla Foundation Blog"
    link = "https://foundation.mozilla.org/blog/"
    feed_url = "https://foundation.mozilla.org/blog/rss/"
    description = "The Mozilla Foundation Blog"

Using relative URLs, the syndication framework will construct an absolute URL for the feed using the current site.

┆Issue is synchronized with this Jira Task

@simont-cr simont-cr added the p2 this works should get done when all p1 have been resolved label Feb 28, 2024
@danielfmiranda
Copy link
Collaborator

Closing this issue as the fix has made it to prod vis #12228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup engineering needs grooming p2 this works should get done when all p1 have been resolved
Projects
None yet
Development

No branches or pull requests

3 participants