Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dist files were not rebuilt for v0.0.6 or v0.0.5 #152

Open
palloberg opened this issue Oct 2, 2024 · 2 comments
Open

The dist files were not rebuilt for v0.0.6 or v0.0.5 #152

palloberg opened this issue Oct 2, 2024 · 2 comments

Comments

@palloberg
Copy link
Contributor

For the release of v0.0.6 and v0.0.5 of the action, the files in the dist/ folder were not built and committed to the repo. As those are the ones called when the action is executed (as defined in action.yml) the action is in effect running on the code built 5 months ago for v0.0.4.

The release process should probably be updated with a step to do npm run build and commit/push the changes in dist/ before tagging the release.

@sylvestre
Copy link
Collaborator

which files ?
running npm run build only updates dist/setup/index.js
is that expected?

@palloberg
Copy link
Contributor Author

Not sure why the dist/show_stats/index.js is not rebuilt, but looking at package.json running build is calling build-dist which does update both dist/setup and dist/show_stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants