Removing eval() for performance, usage was also causing variable collision in some minifiers #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eval() inside multisort() was causing minifier variable collision with a few minifiers. Since this eval isn't necessary it might as well be removed so the browser can also optimize the code path.
|
Wow that's fantastic Nick! I never got around to figuring out how to remove the eval. Your help is very much appreciated! |
Mottie
added a commit
that referenced
this pull request
Nov 21, 2012
Removing eval() for performance, usage was also causing variable collision in some minifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eval()insidemultisort()was causing minifier variable collision with a few minifiers. Since thisevalisn't necessary it might as well be removed so the browser can also optimize the code path. Allowing all modern browsers to be able to JIT here can result in quite a speed boost for large datasets, the more correlated the data (better branch prediction) the faster the speedup will be.I'm mainly fixing this for the minification issue, but if we can improve performance at the same time, win-win.