Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroller full height #907

Closed
Mottie opened this issue May 13, 2015 · 3 comments
Closed

Scroller full height #907

Mottie opened this issue May 13, 2015 · 3 comments

Comments

@Mottie
Copy link
Owner

Mottie commented May 13, 2015

Enhancement request: leave scroller_height undefined (null) to leave table at full height (fixed columns needed) - see Stackoverflow.

@jasongabel
Copy link
Contributor

It could be as simple as adding this around line 250 of the scroller widget, which then if you put in anything 0 or less, the scroller widget does not set a max-height to the outer div

// use max-height, so the height resizes dynamically while filtering

if (maxHt > 0) {
$table.wrap('<div class="' + tscss.scrollerTable + '" style="max-height:' + maxHt + 'px;" />');
}
else {
$table.wrap('<div class="' + tscss.scrollerTable + '"  />');
}

@Mottie
Copy link
Owner Author

Mottie commented Feb 24, 2016

Hi @jasongabel!

Did you test that change? I'll try to look into it this weekend, but it would be awesome if you would send me a PR! 😁

@jasongabel
Copy link
Contributor

Tested in code I am running, not necessarily in jshint or grunt.
Works as expected, meaning that the scroll bar maybe far away, but scroll mouse and arrows allow you to scroll left and right before going all the way to the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants