Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter widget ignores child rows #8

Closed
bignall opened this issue Nov 8, 2011 · 3 comments
Closed

filter widget ignores child rows #8

bignall opened this issue Nov 8, 2011 · 3 comments
Labels

Comments

@bignall
Copy link

bignall commented Nov 8, 2011

When you have child rows marked with expand-child, tablesorter doesn't keep them together with the parent, so if you have a second match it replaces the child of the first row. For example:

first column, first row second column first row
first child row
first column, second row second column, second row
second child row

with this you can see that if you filter it you'll see the second row in place of the first child.

@Mottie
Copy link
Owner

Mottie commented Nov 8, 2011

Hmmm, this may be a bit more difficult to fix since in the child row demo, the table cells span across several cells, so the script ignores them. I guess I could make it completely ignore the child rows for now. Hmm, I don't like that idea either. Give me some time to think about it.

@Mottie
Copy link
Owner

Mottie commented Nov 8, 2011

Ok, I think I figured it out... basically I made an option called widgetFilterChildRows.

When it's true, ALL child row content is included when checking the filter - this is because the child row spans across multiple columns. When false, the child row content is completely ignored.

I made a new demo that allows you to toggle this option to see the difference.

I hope that works for you!

@bignall
Copy link
Author

bignall commented Nov 8, 2011

Awesome, great job! Plugged it in and it worked perfectly. Thank you for the quick response.

@Mottie Mottie closed this as completed Nov 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants