Percent sign breaks text sorting

[MelTraX]

Example: http://jsfiddle.net/CuHbQ/1/

And yes, this is a real life example apart from changed names. :D

I changed my parser to this:

    ts.addParser({
        id: "percent",
        is: function(s) {
            return (/[0-9,.]+ *[$€%]\)?$/).test($.trim(s));
        },
        format: function(s) {
            return $.tablesorter.formatFloat(s.replace(/[^0-9.,]/g, "").replace(/,/g, "."));
        },
        type: "numeric"
    });

Kinda combining currency and percent but that's probably not how you want to do it. :D

I need auto-detection of German and English numbers and luckily I don't have delimiters for thousands. I'll probably even combine percent, currency and digit.

[Mottie]

Hi MelTraX!

Combining currency and percent is fine, in fact the dealing with digits demo has a total column which should be set to currency, but is instead set to digit because the first cell in the column doesn't have a currency symbol, but the column still sorts properly.

The format function does need some changes:

• Using s.replace(/[^0-9.,]/g,'') as this will replace alphabetic characters with an empty string and thus break the string functionality which allows sorting strings in numerical columns. So that can be changed to match the currency format which also needs to not replace parenthesis or a dash (negative numbers) s.replace(/[^\w,. \-()]/g, "")
• Using .replace(/,/g, ".") will break some formats. It'd be best to just remove that since the formatFloat function checks the value of the table.config.usNumberFormat option before replacing the comma.

I was thinking about just changing the percent parser to the following, it seems to work, but then again I know you're using a different numerical format:

ts.addParser({
    id: "percent",
    is: function(s) {
        return (/\d%\)?$/).test(s);
    },
    format: function(s, table) {
        return ts.formatFloat(s.replace(/%/g, ""), table);
    },
    type: "numeric"
});

[Mottie]

I went ahead and made the above change to the percent parser in version 2.3.2. Please let me know if you run into any problems with it! Thanks!

[Mottie]

This should now be resolved, so I'm going to go ahead and close this issue. If you continue to have problems, please feel free to reopen this issue. Thanks!