Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi column sorting - chrome #43

Closed
thezoggy opened this issue Mar 31, 2012 · 7 comments
Closed

multi column sorting - chrome #43

thezoggy opened this issue Mar 31, 2012 · 7 comments
Labels

Comments

@thezoggy
Copy link
Collaborator

http://oi44.tinypic.com/15y9rhx.jpg

chrome: 18.0.1025.142
if you try that same sort in any other browser.. it works as expected...

here is a demo: http://jsfiddle.net/VW4HX/8/embedded/result/

to see the chrome bug, load that demo as it is.. in both chrome and safari/ie/firefox. notice the null isoDate values are not sorted in chrome like they are in the other browsers.

besides the chrome thing.. i also found a quirk. if you look at how its initially being sorted.. scroll down to the null isoDate entries.. notice that its sorting in the opposite direction for the show names than whats being shown in the header. if you hold shift and click on the show name column once.. it fixes this. and note that the image doesnt change.

@Mottie
Copy link
Owner

Mottie commented Mar 31, 2012

Hmm, that is odd. And the need to click on the header twice is also a problem, but I think both are caused by the same issue. Thanks for reporting this! I'll look into fixing it soon.

@thezoggy
Copy link
Collaborator Author

coo. I just thought it was odd that chrome does it.

Sent from my Windows Phone
From: Rob G
Sent: 3/31/2012 6:42 AM
To: thezoggy
Subject: Re: [tablesorter] multi column sorting - chrome (#43)
Hmm, that is odd. And the need to click on the header twice is also a
problem, but I think both are caused by the same issue. Thanks for
reporting this! I'll look into fixing it soon.


Reply to this email directly or view it on GitHub:
#43 (comment)

Mottie added a commit that referenced this issue Mar 31, 2012
@Mottie
Copy link
Owner

Mottie commented Mar 31, 2012

I was seeing the problem in Firefox as well... but it should all be fixed now :) Thanks for all of your diligent testing!

@thezoggy
Copy link
Collaborator Author

damn your quick. thanks!

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 1, 2012

made this to say thank you :)
http://youtu.be/Ekn55VyeqNQ?hd=1

@Mottie
Copy link
Owner

Mottie commented Apr 1, 2012

LOL nice, I've been busy!

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 2, 2012

can confirm this is now fixed. closing

@thezoggy thezoggy closed this as completed Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants