Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveSort - multiple tables #41

Closed
thezoggy opened this issue Mar 26, 2012 · 13 comments
Closed

saveSort - multiple tables #41

thezoggy opened this issue Mar 26, 2012 · 13 comments
Labels

Comments

@thezoggy
Copy link
Collaborator

tablesort saveSort seems to only save the last table data.

@thezoggy
Copy link
Collaborator Author

could just be that widgets is broken in 2.1.6.. as debug: true doesnt even work.

@thezoggy
Copy link
Collaborator Author

about saveSort being broken in 2.1.6: as reported by one of our users
http://pastebin.com/raw.php?i=DaUrQify

@thezoggy
Copy link
Collaborator Author

had him downgrade to widget code 2.1.3.1 but keep 2.1.6 tablesorter.. since this is what im going to do now to resolve the other bugs. and he confirmed that sortSave still wont work. so appears to be a legit bug. yes each tablesorter table has its own unique id.

@Mottie
Copy link
Owner

Mottie commented Mar 27, 2012

Thanks for reporting this issue. It should now be fixed in 2.1.7.

@thezoggy
Copy link
Collaborator Author

ok, let me test this with 2.1.8 and get back to you.

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 1, 2012

still not fixed. created a demo for ya. set the top 250 sort to something.. then set the bottom 100 to another sort. refresh page. notice top table resets to default (sorting didnt save). but the bottom table sorting does save.
http://jsfiddle.net/vCTHw/28/embedded/result/

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 1, 2012

tried $('table').tablesorter thinking that it may just not like multiple instances.. but same problem:
http://jsfiddle.net/vCTHw/29/embedded/result/

@Mottie
Copy link
Owner

Mottie commented Apr 2, 2012

Alright I think it's all fixed now. Thanks again for testing so thoroughly :)

Oh, and I even updated the saveSort demo page to show two tables.

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 2, 2012

alright cool. i'll update and get back to you :)

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 2, 2012

ok, it does save sorting... but messes up when you have a multi-column sort

go try your own demo with multiple column sorts...
http://mottie.github.com/tablesorter/docs/example-widget-savesort.html

looks like it recalls what it should sort by.. but messes up on loading.

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 2, 2012

also, after setting a multi-column sort on the 2nd table. if i just set a new sort.. hit refresh.. it has some of the previous sorts loaded.. gone all crazy

@Mottie
Copy link
Owner

Mottie commented Apr 2, 2012

Ok, try again :P

@thezoggy
Copy link
Collaborator Author

thezoggy commented Apr 8, 2012

confirm that this works as it should. closing

@thezoggy thezoggy closed this as completed Apr 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants