Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveRows Error #4

Closed
meshaabi opened this issue Oct 13, 2011 · 7 comments
Closed

RemoveRows Error #4

meshaabi opened this issue Oct 13, 2011 · 7 comments
Labels

Comments

@meshaabi
Copy link

Removerows set to false breaks addRows and Sorting.

workaround :

  • remove config.appender = null; on line 205 in tablesorter.pager.js
    *addRows needs to be called after manually appending the row to tbody.

Couldn't find a way to get sorting working.

@Mottie
Copy link
Owner

Mottie commented Oct 13, 2011

Hey thanks for reporting this problem... I've been working on the pager plugin to allow deleting rows with or without setting the removeRows option to false. Stay tuned!

@Mottie
Copy link
Owner

Mottie commented Oct 14, 2011

Ok I just pushed version 2.0.22 with some pager plugin improvements. I set it with removeRows set to false by accident, but it appears to work no matter how you set it now :)

@meshaabi
Copy link
Author

Hey Rob,

Thanks I'll try it out, I have developed a deep liking for this plugin
because it eased me out through a couple of university projects. I was very
exited to see that its still being maintained since compared to some of the
other ones out there its relatively much more lightweight.

Great job :),
Shaabi

On 14 October 2011 03:01, Rob G <
[email protected]>wrote:

Ok I just pushed version 2.0.22 with some pager plugin improvements. I set
it with removeRows set to false by accident, but it appears to work no
matter how you set it now :)

Reply to this email directly or view it on GitHub:
#4 (comment)

@Mottie
Copy link
Owner

Mottie commented Oct 14, 2011

I'm glad people are finding it useful! I've used the original for many projects too and figured it was time to give it some lovin'

LOL, And I guess it is pretty lightweight. It's been bugging me that the uncompressed file size is over 30kb now, but then I saw the DataTables source... 224kb, that's 2x bigger than jQuery! But it does a whole bunch of great stuff that isn't in tablesorter... hmmm, should I add column sorting? twitch - I think it can wait for a while LOL

@Mottie
Copy link
Owner

Mottie commented Oct 26, 2011

I'm guessing this issue is now resolved, so I'm closing it.

@Mottie Mottie closed this as completed Oct 26, 2011
@Mottie
Copy link
Owner

Mottie commented Jan 2, 2012

@hackfanatic Sure, here's the link; but I have to tell you, I'm not much of a Twitter/LinkedIn/Facebook fanatic, I hardly ever use them. I make Github auto-post to Twitter for me LOL.

@meshaabi
Copy link
Author

meshaabi commented Jan 4, 2012

Oh, Lol automailing :/, Sorry about this. Thanks for the contact anyways. I myself dont bother much with social networking. Good Job on TS, been following your updates :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants