Zepto Compatibility

[mohitmayank]

Any way to make the plugin compatible with zepto. As of now it fails in adding tablesorter to zepto's namespace. line no 1277.

[Mottie]

Hi @mohitmayank!

I wouldn't mind working on support for Zepto, but with all the other work I have ahead of me, I don't think I want to try to port over the jQuery UI components used by the filter formatter; unless they have already been done?

I'll try to look at this next week. Thanks for reminding me!

[mohitmayank]

initially we can ignore that part. right? i can help in porting the filter
formatter in due course.

On Sat, Oct 26, 2013 at 12:02 AM, Rob G [email protected] wrote:

Hi @mohitmayank https://github.com/mohitmayank!

I wouldn't mind working on support for Zepto, but with all the other work
I have ahead of me, I don't think I want to try to port over the jQuery UI
components used by the filter formatter; unless they have already been done?

I'll try to look at this next week. Thanks for reminding me!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/398#issuecomment-27115413
.

[Mottie]

Wow, this is going to be a pain...

I ended up reformating the entire plugin - not that big a deal

But then I realized I use css selectors alot! Should I force people to include the "optional" selector module, or should I try to code around that?

I haven't even touched the widgets or pager... I'm sure that'll be fun LOL.

[mohitmayank]

as of now i think its a question of how much re-factoring. if its too much, using optional selector module is a good idea. if the problem is only because of jquery's selector extensions, http://api.jquery.com/category/selectors/jquery-selector-extensions/, i think a workaround will do. or you can take the parts of optional selector module which you need and include that within your code.

people use zepto cause of performance issues. for mobile apps jquery becomes a huge lib. for css selectors neither optional module nor patching approach adds too much to the user. its purely a development decision.

[mohitmayank]

And i agree it will be fun. :) i started doing it myself. and ended up at the very first $.fn.extend. you re-factor the core plugin first and submit it. i will work on the widgets. as for pager, that's going to be all hell break loose.

[Mottie]

Hi @mohitmayank!

I have just pushed version 2.13.0, which includes a development branch. In that branch, I have restructured & reorganized the core plugin, then added some basic Zepto support.

Things I'm having trouble with:

1. Getting the test-zepto.html file to pass - I just can't seem to get the initialized, sortStart, sortBegin and sortComplete events to fire on that test page. I even have the events.js file loaded.
2. Most of the widgets should be working, except for the filter widget... I need to either figure out if zepto has nextAll and/or nextUntil or write it in plain js.

I think that's it so far.

[mohitmayank]

thanks man. i just came from a long vacation. i'll see the code right away.
will contribute when i can.

[Mottie]

Welcome back! I didn't get around to updating the development branch with the changes from the last update, since I have to manually do them all now (probably doing that wrong, but I always get merge conflicts).

[mohitmayank]

this is tricky. even after fighting with it for hours i have nothing to contribute. the only thing i know for sure as of now is whole zepto event isnt working in that script.