Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic correction of the table size #1183

Closed
TomFly74 opened this issue Mar 23, 2016 · 6 comments
Closed

Dynamic correction of the table size #1183

TomFly74 opened this issue Mar 23, 2016 · 6 comments

Comments

@TomFly74
Copy link

Hello !
sorry for my English :)
If using a dynamic table width, I suggest to add these following lines in the file "jquery.tablesorter.widgets.js" @lines: 2451 ( Widget: stickyHeaders - updated 3/1/2016 (v2.25.5) )
Code:
//resize row sticky Header Dynamical
$table.resize(function() {
resizeHeader();
});

if corrects the bug on "sticky header" who do not take all size table in case of dynamic expansion of the table such as the expansion of the table by a cursor (col-cursor) to the "div" that contains the table.

Here the bug picture:
bug tablesorter

Here the image of the correction "sticky header":
bug tablesorter -correction

TomFly74

@Mottie
Copy link
Owner

Mottie commented Mar 23, 2016

Hi @TomFly74!

Thanks for reporting this problem! What line number would that be in the widget-stickyHeaders.js file?

Do you know Git well enough to provide a pull request?

@TomFly74
Copy link
Author

Hi @Mottie !

The line number in the file "widget-sticky Headers.js" is 268 (addition of code).

No, I do not think it useful;)
unless this feature could be more fluid because it changes in spurts,

@Mottie
Copy link
Owner

Mottie commented Mar 23, 2016

Oh, last thing. Would you set up a demo (modify this one), so I can test the change to make sure it is fixed? Thanks!

@TomFly74
Copy link
Author

without modification:
http://jsfiddle.net/TomFly74/f36416oy/18/
Try to move the cursor:
bug tabl js

With the modification
http://jsfiddle.net/TomFly74/f36416oy/20/

@Mottie Mottie closed this as completed in 8ed9156 Mar 23, 2016
@Mottie
Copy link
Owner

Mottie commented Mar 23, 2016

Ok, thanks again for your help! The fix is currently only available in the master branch (in the widget-stickyHeaders.js and widget-stickyHeaders.min.js, not the jquery.tablesorter.widgets.js file). I'm not sure yet when the next version will be released.

@Mottie
Copy link
Owner

Mottie commented Apr 1, 2016

A new release is now available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants