Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't leave comment when hiding comments #122

Open
xmo-odoo opened this issue Aug 4, 2020 · 4 comments
Open

Can't leave comment when hiding comments #122

xmo-odoo opened this issue Aug 4, 2020 · 4 comments
Labels

Comments

@xmo-odoo
Copy link

xmo-odoo commented Aug 4, 2020

This extension got my interest because on some PRs with lots of inline comments traffic it can be difficult to even see the code inbetween the comments.

I wanted the ability to see the PR as if it were brand new, for clarity. However, when hiding comments the new comments are also hidden, making this idea impossible.

Collapsing comment allows writing new ones, but still leaves rather large gaps in the file, which are somewhat confusing as they look a lot like hunk changes (especially when using the Github Dark stylus theme, as the hunk header has a color scheme rather undifferentiated from the background itself, making it less differentiable than the blue/white of the default color scheme).

@Mottie Mottie added the bug label Aug 4, 2020
@Mottie
Copy link
Owner

Mottie commented Aug 9, 2020

Hi @xmo-odoo!

Sorry for not responding earlier. I just fixed a bunch of other stuff, but forgot about this issue. Sorry... it'll probably have to wait another week until I have more time to work on it.

@xmo-odoo
Copy link
Author

@Mottie no worries, it's no worse than before I installed the userscript so it's hardly a life-and-death issue

@Mottie Mottie closed this as completed in 7805951 Sep 30, 2020
@Mottie
Copy link
Owner

Mottie commented Sep 30, 2020

I haven't thoroughly tested this update, but it seems to be working as expected.

@xmo-odoo
Copy link
Author

It seems to work fine when collapsing comments but not when hiding comments

Here's a screencast, as you can see when using "Collapse" the new comment box still appears, but when using "hide" it's not possible to open an editor.

Again my use case is a bit specific so I can understand if you decide not to support it: on some pull requests there are dozens of comments on the diff so it's very hard to read the code and leave comments as the diff is completely broken up by interspersed comments, so I wanted to fold the existing comments in order to get a "unified view" of the PR diff in order to have an easier time reading and commenting (then un-collapse and check if my comments were redundant with existing ones I guess).

@Mottie Mottie reopened this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants