Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philisophical discussion on some future PRs #253

Open
Ryan-DowlingSoka opened this issue Dec 19, 2024 · 1 comment
Open

Philisophical discussion on some future PRs #253

Ryan-DowlingSoka opened this issue Dec 19, 2024 · 1 comment

Comments

@Ryan-DowlingSoka
Copy link
Contributor

Something I find myself wanting is more dynamic control of the SFlowGraphNode from the UFlowNode without having to make more SFlowGraphNodes

Locally i've made changes to allow the UFlowNode to optionally set a node width override, add an icon, and allow wordwrap on the title text.

Are these the types of things y'all would consider worth taking? Or should I live with these as local plugin changes to just keep track of in the future.

@MothDoctor
Copy link
Contributor

As a rule, I wouldn't add a particular change like "node width" used very rarely, but expanding the codebase a bit, adding maintenance time, etc. Especially, if this would only add "node width", but not "node height".

Although I'm open to adding something that might be commonly used. Here's a great example is icon displayed in the top corner of the node. Implemented in a way where any user could add a pair of Gameplay Tag and icon. This way plugin currently allows to set the color of the node body.

I would also accept some generalized mechanism (or "groundwork code") allowing easier customization, without further plugin modifications :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants