Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0: Fully Qualified Type Information #7

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

MooVC
Copy link
Owner

@MooVC MooVC commented Aug 5, 2024

Changed

  • The fully qualified type information for the subject upon which Fluentify has been placed is now captured and utilized when generating extensions, thereby enabling support for nested classes (Support for Nested Types #3).
  • Utilized Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing to improve the quality of the Generator tests.

Fixed

  • The generated code files no longer include the namespace if the containing namespace is global (Extensions fail to generate when Class is placed in the Global Namespace #6).
  • The generated code files for classes now apply a conditional preprocessor directive to #nullable calls to prevent compilation failure in .NET Standard 2.0 projects.
  • The generated extensions no longer call ArgumentNullException.ThrowIfNull to prevent compilation failure in .NET Standard 2.0 projects.
  • The generated extensions no longer use pattern matching to prevent compilation failure in .NET Standard 2.0 projects.
  • The generated constructor for records now applies a preprocessor directive to the SetRequiredMembers attribute to prevent compilation failure in .NET 6 projects (Compilation Failure on Generated Record Constructor for .NET 6 #5).

- The fully qualified type information for the subject upon which Fluentify has been placed is now captured and utilized when generating extensions, thereby enabling support for nest classes.

#3
- The fully qualified type information for the subject upon which Fluentify has been placed is now captured and utilized when generating extensions, thereby enabling support for nest classes (#3).
- Utilized Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing to improve the quality of the Generator tests.

## Fixed

- The generated code files for classes now apply a conditional preprocessor directive to #nullable calls to prevent compilation failure in .NET Standard 2.0 projects.
- The generated extensions no longer call ArgumentNullException.ThrowIfNull to prevent compilation failure in .NET Standard 2.0 projects.
- The generated extensions no longer use pattern matching to prevent compilation failure in .NET Standard 2.0 projects.
- The generated constructor for records now applies a preprocessor directive to the SetRequiredMembers attribute to prevent compilation failure in .NET 6 projects (#5).
- The generated code files no longer include the namespace if the containing namespace is global (#6).
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (dd6bf97) to head (9479404).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   94.64%   96.32%   +1.68%     
==========================================
  Files          83       86       +3     
  Lines        1120     1170      +50     
  Branches       93       95       +2     
==========================================
+ Hits         1060     1127      +67     
+ Misses         38       22      -16     
+ Partials       22       21       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooVC MooVC merged commit 99743d4 into master Aug 5, 2024
4 checks passed
@MooVC MooVC deleted the feature/3-pm-nestedtypes branch August 5, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant