Skip to content

Commit

Permalink
video: bcm2708_fb: Disable FB if no displays found
Browse files Browse the repository at this point in the history
Source: kernel.org
MR: 103889
Type: Enhancement
Disposition: Merged from https://github.com/raspberrypi/linux.git rpi-5.4.y
ChangeID: e005a4db95a48e8b14a2017bf56a0e3f3dccfa6d
Description:

If the firmware hasn't detected a display, the driver would assume
one display was available, but because it had failed to retrieve the
display size it would try to allocate a zero-sized buffer.

Avoid the allocation failure by bailing out early if no display is
found.

See: raspberrypi/linux#3598

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Corey Minyard <[email protected]>
  • Loading branch information
pelwell authored and cminyard committed Jun 4, 2020
1 parent d4d181f commit 60434ff
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/video/fbdev/bcm2708_fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1104,10 +1104,9 @@ static int bcm2708_fb_probe(struct platform_device *dev)
* set one display
*/
if (ret || num_displays == 0) {
num_displays = 1;
dev_err(&dev->dev,
"Unable to determine number of FB's. Assuming 1\n");
ret = 0;
"Unable to determine number of FBs. Disabling driver.\n");
return -ENOENT;
} else {
fbdev->firmware_supports_multifb = 1;
}
Expand Down

0 comments on commit 60434ff

Please sign in to comment.