Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Twitter window reaction to X #10211

Closed
dreamscached opened this issue Feb 21, 2024 · 23 comments
Closed

Adjust Twitter window reaction to X #10211

dreamscached opened this issue Feb 21, 2024 · 23 comments
Labels
discussion treat this issue/pr as a debate/discussion point

Comments

@dreamscached
Copy link
Member

init 5 python:
addEvent(
Event(
persistent._mas_windowreacts_database,
eventlabel="mas_wrs_twitter",
category=["/ Twitter"],
rules={
"notif-group": "Window Reactions",
"skip alert": None,
"keep_idle_exp": None,
"skip_pause": None
},
show_in_idle=True
),
code="WRS"
)

Nuff said. Twitter is now X and the window reaction has to be adjusted. I would've created a PR myself but I'm concerned if changing the category would require a persistent modifications.

Screenshot of Monika X profile tab

@dreamscached dreamscached added the discussion treat this issue/pr as a debate/discussion point label Feb 21, 2024
@Booplicate
Copy link
Member

Or we could intentionally keep it Twitter

@dreamscached
Copy link
Member Author

My suggestion as a middle ground is to keep both, if the window reaction framework allows that.

@Booplicate
Copy link
Member

Jokes aside, I'm a little afraid of porn sites reacts if we keep it as just / x

@dreamscached
Copy link
Member Author

dreamscached commented Feb 21, 2024

Weeeell... yeah. But in case of X/Twitter we could react on stuff that looks exactly like

Name (@handle) / X

If possible. That is an issue with X-sites yeah, but if we trim the string, there should just / X be left at the end?

P.S. Alternatively, why don't we just match the @lilmonix thing exactly?

@TheBearodactyl
Copy link

init 5 python:
addEvent(
Event(
persistent._mas_windowreacts_database,
eventlabel="mas_wrs_twitter",
category=["/ Twitter"],
rules={
"notif-group": "Window Reactions",
"skip alert": None,
"keep_idle_exp": None,
"skip_pause": None
},
show_in_idle=True
),
code="WRS"
)

Nuff said. Twitter is now X and the window reaction has to be adjusted. I would've created a PR myself but I'm concerned if changing the category would require a persistent modifications.

Screenshot of Monika X profile tab

maybe just make it react to x.com but have it shown as twitter since nobody calls it "X" anyways

@dreamscached
Copy link
Member Author

dreamscached commented Jun 21, 2024

However, it's 'X' now and I think we should reflect the change. It'll sure take a while for people to move on from it (and they themselves at X kind of stall at that migration), but it's no longer Twitter really.

@TheBearodactyl
Copy link

However, it's 'X' now and I think we should reflect the change. It'll sure take a while for people to move on from it (and they themselves at X kind of stall at that migration), but it's no longer Twitter really.

it is twitter. if elon won't call his daughter by her prefered name, we shouldn't call Twitter X. simple as that

@dreamscached
Copy link
Member Author

I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially.

@TheBearodactyl
Copy link

I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially.

loophole time :D

https://x.com/racistriamu/status/1686945859320369152

@TheBearodactyl
Copy link

also
image_2024-06-21_160319548

@dreamscached
Copy link
Member Author

dreamscached commented Jun 21, 2024

Like I said, I do admit they stall at the migration at the moment. The frontpage however is located at x.com and their company name is 'X'.

Source 1
Source 2 (this one deserves attention)

@TheBearodactyl
Copy link

Like I said, I do admit they stall at the migration at the moment. The frontpage however is located at x.com and their company name is 'X'.

Source 1 Source 2 (this one deserves attention)

And like i said, who tf cares if elon wants to call it X, it's twitter and it will always be twitter.

@Booplicate
Copy link
Member

@TheBearodactyl they won't get rid of the old domain because it worth a lot, it'd be a waste and many links would become dead. It's not really a proof. People call it both X and Twitter now.

I still think due to the stupid name we should probably just remove the react. The amount of false positives you get is too high. There's just 3 characters to match.

@TheBearodactyl
Copy link

TheBearodactyl commented Jun 21, 2024

@TheBearodactyl they won't get rid of the old domain because it worth a lot, it'd be a waste and many links would become dead. It's not really a proof. People call it both X and Twitter now.

I still think due to the stupid name we should probably just remove the react. The amount of false positives you get is too high. There's just 3 characters to match.

they did get rid of the old domain on the main site
but yeah, agreed. maybe replace it with bluesky?

@Booplicate
Copy link
Member

they did get rid of the old domain on the main site but yeah, agreed. maybe replace it with bluesky?

Last time I checked they still owned the domain and it still leads to X.

@dreamscached
Copy link
Member Author

dreamscached commented Jun 21, 2024

I agree with removing the react, to be honest. @lilmonix3 is seemingly (to me) a canon thing endorsed by Team Salvato, but whoever holds the handle posts rarely and it doesn't quite (again, to me) align with MAS 'canon'.

@TheBearodactyl
Copy link

they did get rid of the old domain on the main site but yeah, agreed. maybe replace it with bluesky?

Last time I checked they still owned the domain and it still leads to X.

they still own the domain, but it only redirects now. it is just x.com now (except for the help page for some reason)

@dreamscached
Copy link
Member Author

dreamscached commented Jun 21, 2024

Google owns many typesquatter domains that redirect to the true one, doesn't imply we can call it 'googel' or whatever.

@Booplicate
Copy link
Member

@dreamscached the lilmonix is a different react and iirc it's disabled already

they still own the domain, but it only redirects now

Which is why I said they didn't and won't get rid of it.

@dreamscached
Copy link
Member Author

@dreamscached the lilmonix is a different react and iirc it's disabled already

I know, just mentioned it as a point towards removing this react too. I don't see a real use for it, unlike Wikipedia or MAS Discord (or do we not have a react for that? I don't remember.)

@TheBearodactyl
Copy link

i just opened a PR that would change Twitter to bluesky

@meoowmeowman

This comment was marked as off-topic.

@dreamscached
Copy link
Member Author

Closing as there's #10269 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion treat this issue/pr as a debate/discussion point
Projects
None yet
Development

No branches or pull requests

4 participants