-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Twitter window reaction to X #10211
Comments
Or we could intentionally keep it |
My suggestion as a middle ground is to keep both, if the window reaction framework allows that. |
Jokes aside, I'm a little afraid of porn sites reacts if we keep it as just |
Weeeell... yeah. But in case of X/Twitter we could react on stuff that looks exactly like
If possible. That is an issue with X-sites yeah, but if we trim the string, there should just P.S. Alternatively, why don't we just match the |
maybe just make it react to |
However, it's 'X' now and I think we should reflect the change. It'll sure take a while for people to move on from it (and they themselves at X kind of stall at that migration), but it's no longer Twitter really. |
it is twitter. if elon won't call his daughter by her prefered name, we shouldn't call Twitter X. simple as that |
I don't think Elon's family relations are relevant in the question. The website and the company were renamed to X, officially. |
loophole time :D |
@TheBearodactyl they won't get rid of the old domain because it worth a lot, it'd be a waste and many links would become dead. It's not really a proof. People call it both X and Twitter now. I still think due to the stupid name we should probably just remove the react. The amount of false positives you get is too high. There's just 3 characters to match. |
they did get rid of the old domain on the main site |
Last time I checked they still owned the domain and it still leads to X. |
I agree with removing the react, to be honest. @lilmonix3 is seemingly (to me) a canon thing endorsed by Team Salvato, but whoever holds the handle posts rarely and it doesn't quite (again, to me) align with MAS 'canon'. |
they still own the domain, but it only redirects now. it is just |
Google owns many typesquatter domains that redirect to the true one, doesn't imply we can call it 'googel' or whatever. |
@dreamscached the lilmonix is a different react and iirc it's disabled already
Which is why I said they didn't and won't get rid of it. |
I know, just mentioned it as a point towards removing this react too. I don't see a real use for it, unlike Wikipedia or MAS Discord (or do we not have a react for that? I don't remember.) |
i just opened a PR that would change Twitter to bluesky |
This comment was marked as off-topic.
This comment was marked as off-topic.
Closing as there's #10269 already. |
MonikaModDev/Monika After Story/game/script-windowreacts.rpy
Lines 267 to 282 in 06baf31
Nuff said. Twitter is now X and the window reaction has to be adjusted. I would've created a PR myself but I'm concerned if changing the category would require a persistent modifications.
The text was updated successfully, but these errors were encountered: