Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCUMENTATION] incompatibility with module Multiattack-5e #41

Closed
davidR1974 opened this issue Jan 5, 2021 · 3 comments
Closed

[DOCUMENTATION] incompatibility with module Multiattack-5e #41

davidR1974 opened this issue Jan 5, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation Module Incompatibility wontfix (PR welcome) This will not be worked on by Moerill. Pull requests are welcome.

Comments

@davidR1974
Copy link

Describe the bug
Incompatbility with module MultiAttack-5e

Module incompatibilities
The MultiAttack-5e (https://github.com/jessev14/Multiattack-5e) interfers with MARS-5e : no action happens when clicking on items and the following message appears in console :

override.js:491 Uncaught (in promise) TypeError: Cannot read property 'altKey' of null
at damageRollMA5e (override.js:491)
at Item5e.rollDamageMA5e (override.js:435)
at MarsItem5e.rollDamage (entity.js:257)
at MarsItem5e._getTemplateData (entity.js:118)
at async MarsItem5e.displayCard (entity.js:13)

Deactivating module Multiattack-5e solve the issue completely.

Desktop (please complete the following information):

  • OS: Windows10
  • Browser : tested on "server side"
  • FVTT Version : 0.7.9 (with Plutonium 0.2.0 and dnd5e 1.2.0)
  • Module version : 1.1.0

Additional context

@davidR1974 davidR1974 added the bug Something isn't working label Jan 5, 2021
@davidR1974
Copy link
Author

Great job on the whole module. .. I wanted to tag this as "documentation" but was not able to find where to change the tag....

@Moerill Moerill added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jan 5, 2021
@Moerill
Copy link
Owner

Moerill commented Jan 5, 2021

Thanks for the info!
And no problem, not sure if you're allowed to change the label?
it would be at the right side under "labels", just click on it and uhm.. maybe it works? dunno 😓
i'll add it to documentation or just do a complete pinned module incompatibility issue at some point..

@Moerill
Copy link
Owner

Moerill commented Jan 7, 2021

Linked to this issue in known module incompatibilties. Will close this, which does not mean its getting resolved, just that i don't want it in the open issue list..

@Moerill Moerill closed this as completed Jan 7, 2021
@Moerill Moerill added wontfix (PR welcome) This will not be worked on by Moerill. Pull requests are welcome. Module Incompatibility labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Module Incompatibility wontfix (PR welcome) This will not be worked on by Moerill. Pull requests are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants