Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot apply damage as a GM on a player's created chat template #105

Open
davelamorte opened this issue Jun 18, 2021 · 5 comments
Open
Labels
bug Something isn't working

Comments

@davelamorte
Copy link

Describe the bug
I think this started to happen with a fix about the players not able to roll their dices on the chat templates with Foundry 0.8.x which I mentioned before and it was fixed.
The new issue is this:

  1. if as a GM I attack using a PNG or a PG, the template is correctly created, I can right click to change if I have hit or not, I can change the damage multiplier, and I can assign the damage with the button, everything works as intended;
  2. if a PLAYER uses the very same attack, the template is correctly created, dices are rolled, BUT as a GM I cannot change anything on it (with the right click) plus I cannot assign the damage (clicking does nothing, not even on the console); it's like even if I'm the GM I don't "own" the template to be able to interact with it.

To Reproduce
Steps to reproduce the behavior:

  1. attack something using a player account
  2. log as a GM and try to interact with the template
  3. nothing happens, and the most visible things are: right click does nothing, cannot assign damage.

Expected behavior
As a GM you should be able to interact with the template as you were the owner, even if it was created by a player.

Desktop (please complete the following information):

  • OS: WIN10 x64 current version
  • Browser: electron / server+client
  • FVTT Version 0.8.7
  • Module version 1.6.2
  • Are you using a hosting provider? self-hosted

As always, thank you for your hard work!

@davelamorte davelamorte added the bug Something isn't working label Jun 18, 2021
@davelamorte
Copy link
Author

I actually see an error on the console, when as a GM I simply move my mouse over the chat template generated by a player:

Uncaught ReferenceError: Config is not defined
at Mars5eMessage._getTarget (message.js:912)
at HTMLOListElement. (message.js:82)

@9ryex5
Copy link

9ryex5 commented Jun 30, 2021

Same happening here, using Foundry 0.8.8

@PaulAshcroft
Copy link

Same for me, disabled all other modules. gm can only apply damage if they orchestrate the attack (i.e click player token, then target enemy, and apply player's attack)

@kenpoh01
Copy link

Same here.

@Jamo181
Copy link

Jamo181 commented Aug 23, 2021

Don't know if I have done this right but the following change seems to have enabled gm apply damage for me. https://github.com/Jamo181/fvtt-mars-5e/commit/0291d8ade85294b5091fa36bc221238d6706854a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants