Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] qpv-plugins are not working properly #137

Closed
Tracked by #136
adriengivry opened this issue Dec 14, 2023 · 3 comments
Closed
Tracked by #136

[BUG] qpv-plugins are not working properly #137

adriengivry opened this issue Dec 14, 2023 · 3 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@adriengivry
Copy link
Contributor

Describe the bug
Plugins are not working anymore, as qpv-plugins hasn't been added as a dependency

To Reproduce
Steps to reproduce the behavior:

  1. Open an image
  2. Select an effect to apply
  3. See error

Expected behavior
We should be able to retrieve the qpv-plugins.dll.

Screenshots
If applicable, add screenshots to help explain your problem.

@adriengivry adriengivry added the 🐞 bug Something isn't working label Dec 14, 2023
@adriengivry adriengivry changed the title [BUG] *title here* [BUG] qpv-plugins are not working properly Dec 14, 2023
@Beelink
Copy link
Member

Beelink commented Dec 21, 2023

@adriengivry I've tried to upgrade to .NET8.0 by myself but I guess I'm doing that in the wrong way because I'm getting a lot of errors.

Could you please help me with that?

That's what I got: https://github.com/ModuleArt/quick-picture-viewer/tree/upgrade/dotnet-8

P.S.
I've merged your QuickLibrary PR.

@Beelink Beelink self-assigned this Dec 21, 2023
@adriengivry
Copy link
Contributor Author

@Beelink I'll look into this ASAP and get back to you

@adriengivry
Copy link
Contributor Author

@Beelink To add qpv-plugins as a dependency, we need this dependency to also be updated to .NET8.0. Here is the PR that updates qpv-plugins to .NET8.0:
ModuleArt/qpv-plugins#9

After that, we should be able to get them to work with quick-picture-viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants