This repository has been archived by the owner on May 14, 2019. It is now read-only.
Adding editorconfig and re-aligning code style with Modernizr #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,209 +2,209 @@ var AppDispatcher = require('../dispatcher/AppDispatcher'); | |||
| var EventEmitter = require('events').EventEmitter; | |||
| var merge = require('react/lib/merge'); | |||
| var MetadataStore = require('./Metadata'); | |||
| var Fuse = require('../../../bower_components/fuse/src/fuse'); | |||
| var Fuse = require('fuse'); | |||
There was a problem hiding this comment.
This wasn't supposed to make it in but it fixes the build from being broken. Webpack couldn't resolve that path and you've added bower_components to the moduleDirectories so webpacks require resolving algorithm will check there already.
ryanseddon
force-pushed
the
issue/8/tabs_be_gone
branch
from
31b053f to
6c7dbcd
Compare
|
looks good, assuming the fuse stuff dosen't break it. |
|
I couldn't build with the previous fuse path, had to change it to what's in this PR to work. |
|
hmm, thats a direct revert of @joecritch's c6476f7 |
|
ok I'll remove that and we can discuss in another pr |
ryanseddon
force-pushed
the
issue/8/tabs_be_gone
branch
from
6c7dbcd to
79cf1ca
Compare
|
Reverted now this is straight formatting only |
patrickkettner
added a commit
that referenced
this pull request
Aug 27, 2014
Adding editorconfig and re-aligning code style with Modernizr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.
Converts tabs to 2 spaces and adds editorconfig make sure you add the plugin to your favourite editor so it picks up the defaults.