Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into and fix(?) behavior of log modification #61

Open
bestchai opened this issue May 27, 2020 · 0 comments
Open

Look into and fix(?) behavior of log modification #61

bestchai opened this issue May 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@bestchai
Copy link
Member

bestchai commented May 27, 2020

What:

  • Currently, whenever logs are edited in any way (including whenever an example button is pressed), the model, invariants, and highlighting are erased.
  • This may not be the correct behavior. This to consider include:
    • When logs are changed, the model, invariants, and highlighting are no longer relevant
    • The user may want to manipulate the logs while looking at the model/invariants, or may hit the logs by accident
    • We previously discussed the model and invariants constantly being updated when logs are manipulated
    • Log highlighting is done by passing the text that should be highlighted to the highlighter. To do this, we find what text is in the input box at the desired line numbers. At the very least, we should remove highlighting for the logs (or redo it) when the logs are modified, as it will no longer work correctly.

Why:

  • We may want to make the logs manipulatable by the user, however we do not want to confuse the user by doing so.

How to measure completeness:

  1. We have discussed and decided on an implementation
  2. We have implemented said implementation

[Issue created by stanleyrya: 2015-10-20]

@bestchai bestchai added the enhancement New feature or request label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant