Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying what heroes get per attribute point #16

Open
darklordabc opened this issue Nov 23, 2016 · 2 comments
Open

Allow modifying what heroes get per attribute point #16

darklordabc opened this issue Nov 23, 2016 · 2 comments

Comments

@darklordabc
Copy link

darklordabc commented Nov 23, 2016

Problem: Points into strength, agility and intelligence gives fixed attributes, like HP regen, armour, magic resistance, and you cannot easily change these (or at all?).

Solution: Allow modders to set custom properties for what these attributes reward

Priority: Low

@darklordabc darklordabc changed the title Allow changing what you get per attribute point Allow modifying what heroes get per attribute point Nov 23, 2016
@SinZ163
Copy link
Member

SinZ163 commented Nov 24, 2016

With the exception of #26 This is fully possible using Lua Modifiers and Lua Spells, with luaSpell:OnHeroCalculateStatsBonus() to reapply the lua modifiers with the intended stack counts.

@Yahnich
Copy link

Yahnich commented Nov 24, 2016

it is possible, but the problem is if you work with big numbers, dropping an item can (due to the 0.03 server tick delay) mean you have 0hp for example for a server tick and you die; so preferably we'd have some kind of integrated method for this or at least some way to just turn the default valve values off

for example you have a 100 strength item and in your gamemode strength gives you 1hp per strength; dropping this item suddenly loses you 20*100 effective hp and you're dead because the health you're deducting makes your max health 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants