Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fares-v2 page with time/day variable fares #170

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Update fares-v2 page with time/day variable fares #170

merged 2 commits into from
Jul 27, 2023

Conversation

isabelle-dr
Copy link
Contributor

@isabelle-dr isabelle-dr commented Jul 27, 2023 •
edited
Loading

Update the Fares v2 extension page after time/day variable fares have been merged in PR#357:

  • Added ITO World to the list of first adopters
  • Removed some of the "In Progress fares v2 Work" text because I think it's covered by the Features under discussion and History sections and it's manually maintained
  • Updated the History section

@isabelle-dr isabelle-dr requested a review from Sergiodero July 27, 2023 14:54
Sergiodero
Sergiodero approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Sergiodero Sergiodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small suggestion on line 24, but nothing too important, so you can decide if we include it or not. Beyond that, all the changes look good to me!

docs/extensions/fares-v2.md Show resolved Hide resolved
@isabelle-dr
Copy link
Contributor Author

Thanks for the review @Sergiodero !

@isabelle-dr isabelle-dr merged commit 5614f7a into main Jul 27, 2023
@isabelle-dr isabelle-dr deleted the update-faresv2-page branch July 27, 2023 15:55
@emmambd emmambd mentioned this pull request Nov 17, 2023
Closed
fredericsimard added a commit that referenced this pull request Mar 20, 2024
@fredericsimard
Merge pull request #170
f86efe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergiodero Sergiodero Sergiodero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabelle-dr @Sergiodero