Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove missing_required_column #1908

Open
emmambd opened this issue Oct 28, 2024 · 0 comments
Open

Remove missing_required_column #1908

emmambd opened this issue Oct 28, 2024 · 0 comments
Assignees
@cka-y
Labels
enhancement New feature request or improvement on an existing feature status: Ready An issue that is ready to be worked on.
Milestone
7.0 Validator Rel...

Comments

@emmambd
Copy link
Contributor

emmambd commented Oct 28, 2024 •
edited
Loading

Describe the problem

As the last outstanding part of #1795, missing_recommended_column can be removed because it is no longer triggered.

Proposed solution

  • Update missing_timepoint_value description to:

"stop_times.timepoint value is missing for a record.

When at least one of stop_times.arrival_time or stop_times.departure_time are provided, stop_times.timepoint should be defined."
Remove missing_required_column notice since it's no longer in use/has relevant pseudologic

Alternatives you've considered

No response

Additional context

No response
@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels Oct 28, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Oct 28, 2024
@emmambd emmambd added status: Ready An issue that is ready to be worked on. and removed status: Needs triage Applied to all new issues labels Jan 27, 2025
@emmambd emmambd changed the title Update missing_timepoint_value to not check for timepoint header Update missing_timepoint_value to check for timepoint header Jan 30, 2025
@cka-y cka-y self-assigned this Jan 30, 2025
@emmambd emmambd changed the title Update missing_timepoint_value to check for timepoint header Remove missing_required_column Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cka-y cka-y

Labels
enhancement New feature request or improvement on an existing feature status: Ready An issue that is ready to be worked on.
Projects
None yet
Milestone
7.0 Validator Release
Development

No branches or pull requests
2 participants
@cka-y @emmambd