Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test optimization #1698

Closed
3 of 5 tasks
emmambd opened this issue Mar 8, 2024 · 4 comments · Fixed by #1771
Closed
3 of 5 tasks

Acceptance test optimization #1698

emmambd opened this issue Mar 8, 2024 · 4 comments · Fixed by #1771
Assignees

Comments

@emmambd
Copy link
Contributor

emmambd commented Mar 8, 2024

We want to make this process less time-intensive. Suggestions so far:

  • Better document filtering
  • Add performance analysis to the acceptance tests so we catch code changes with memory issues
  • Remove auto-run acceptance tests in draft mode
  • Reuse acceptance test reports when possible. Make sure if the master artifacts are +30 days we run the validator.
  • Fix warnings in gh action
@emmambd emmambd added this to the Next milestone Mar 13, 2024
@emmambd emmambd modified the milestones: Next, Now Mar 21, 2024
@cka-y cka-y self-assigned this May 13, 2024
@davidgamez
Copy link
Member

Timebox: 3 days

@emmambd
Copy link
Contributor Author

emmambd commented May 23, 2024

@cka-y An out of scope question but asking since it's coming up as I'm reviewing Flex feeds: the performance test is about the amount of time it takes to parse a feed, correct? I'm wondering as well about getting stats on the number of feeds that have unparsable rows grouped by file

@cka-y
Copy link
Contributor

cka-y commented May 27, 2024

@emmambd -- It's about the amount of time it takes to validate the feed including parsing time. We could look into adding stats about the number of feeds with unparsable errors -- shall we open an issue for that?

@emmambd
Copy link
Contributor Author

emmambd commented May 27, 2024

@cka-y Can do :) Out of scope for this iteration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants