-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OSM opening hours format? #6
Comments
The OSM format looks flexible, but also requires a lot more parsing than the explicit (but admittedly not as flexible) format that we defined in the spec. I'd be concerned with this significant of a change without much more discussion. Specifically, I'd be curious as to how using the OSM format would affect consumers - it seems much more brittle to me. For reference, the current definition is here: https://github.com/NABSA/gbfs/blob/master/gbfs.md#system_hoursjson |
Good objection by @jcn. By using OSM data, we would also lose info about member and non-member opening times, unless we changed the spec to something like
I can also see the clear advantage of using the same libraries for parsing the date as OSM dates which the developer of an application might already be using for parsing opening hours from OSM itself. How could we support differing opening hours for a special event like holidays or strikes? Make that part of system alerts? |
This disucssion has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
We have a proposal to change the format for operation dates and times to OSM Opening Hours format. Since this would be a breaking change it would happen with v3.0. This is a significant revision to the specification so we'd like to get some feedback before it goes to a PR. I've written up the proposal in this document. Please comment along with your willingness to implement. |
Closing this - ongoing discussion of OSM Opening Hours has been moved to #289 |
Are we trying to invent a new format for hours of operation (system_hours.json)?
What about a format that is already used and supported with code libraries—see OSM’s opening_hours (http://wiki.openstreetmap.org/wiki/Key:opening_hours)
The text was updated successfully, but these errors were encountered: