Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying geofencing_zones.json language about intersections #361

Closed
2 tasks
heidiguenin opened this issue Sep 3, 2021 · 2 comments
Closed
2 tasks

Clarifying geofencing_zones.json language about intersections #361

heidiguenin opened this issue Sep 3, 2021 · 2 comments

Comments

@heidiguenin
Copy link
Contributor

What is the issue and why is it an issue?

In the geofencing documentation, rules states:
"In the event of colliding rules within the same polygon, the earlier rule (in order of the JSON file) takes precedence.
In the case of overlapping polygons, the combined set of rules associated with the overlapping polygons applies to the union of the polygons. In the event of colliding rules in this set, the earlier rule (in order of the JSON file) also takes precedence."

As more stakeholders begin implementing geofencing, it has become clear through discussion in the GBFS slack channel (request an invite here) that this language is confusing and does not conform to the intent of the rule. Specifically, the intention is that, in the case of overlapping polygons, the combined set of rules applies to the intersection, not to the union. MobilityData would like to update the language and provide some clarifying examples, but before we do, we want to understand if anyone is currently implementing geofencing_zones.json treating overlapping polygons rules as a geographic union. If not, then we can clarify the language without creating a breaking change and requiring an extra governance step.

Please describe some potential solutions you have considered (even if they aren’t related to GBFS).

Is your potential solution a breaking change?

  • Yes
  • No
  • [ x] Unsure
@josee-sabourin
Copy link
Contributor

Hi all! We talked about this issue during the Developers' Workshop, see details here.

@mplsmitch
Copy link
Collaborator

This is covered in PR #384
#384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants