Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing plans valid time and week day, add services file #298

Closed
1 of 3 tasks
cizmarf opened this issue Mar 23, 2021 · 3 comments
Closed
1 of 3 tasks

Pricing plans valid time and week day, add services file #298

cizmarf opened this issue Mar 23, 2021 · 3 comments
Labels

Comments

@cizmarf
Copy link

cizmarf commented Mar 23, 2021

Who I am

I am working on the project Intermodal Routing Machine for the city of Prague. Currently, I create common data format holding the data of all share mobility providers which should be consume by this routing machine.

What is the issue and why is it an issue?

There are missing important attributes in the pricing plans file or an extra file needs to be created.

I found the share mobility providers who are using different pricing plans valid in chosen day time (morning and night prices may differ) and valid in a week day (special weekend sales) and specials pricing plans.

Examples:
https://anytimecar.cz/rates.html
https://www.rekola.cz/en/pricing

Potential solutions I have considered.

The simplest possible solution is to add those attributes to the pricing plan file.

start_time_of_period: "Mon-Fri 09:00AM",
end_time_of_period: "Mon-Fri 09:00PM",
pricing_plan_description: "member card holders"

To solve this problem in general we would need much more attributes to cover all business pricing plans. I would consider creating an extra file describing the services provided by a vehicle. It means if a bike rental company would decide to make specials for weekend users or provide a student sale or a long-time rental sale we can cover it in this service file. This solution would add one or more services to a vehicle and one or more pricing plans to a service.

The reason for creating an extra file and do not add all the attributes to the pricing plans file is keeping separated the business layer and the simple pricing plans. In other words from the point of view of a customer, the customer would be able to choose the service he/she wants to use (I am student, I am a member card holder) but the pricing plans are connected to the each of those services and cannot be impacted by the customer decision. It is possible to implements all the changes into the pricing plans file but it would break its format by a lot.

Is your potential solution a breaking change?

I do not need to implement those changes in the next version of GBFS format. I would like to discuss the suggestions with you, if it is the good way to develop and extend the GBFS if I base my own format on GBSF or if you plan to implement those changes in the future. Or we can consider any other suggestions how to cover the described problems.

Thank you.

  • Yes
  • No
  • Unsure
@josee-sabourin
Copy link
Contributor

Hi there! Thanks for bringing up this issue and welcome to the repository!

The initial proposal to extend system_pricing_plans.json did include fields to allow for plans that varied based on time, day, or month (albeit not to the level of detail you are suggesting). These were removed to simplify the minimum viable proposal. We would love to discuss this need with you in more depth and see how we can add this into the next phases of the pricing extension (or a whole new phase, see other planned phases here).

I encourage you to look at issue #289 which discusses moving to the OSM hours and dates format and see how that format can potentially be used for this issue as well.

We'd love to discuss this with you in more detail! Send us an e-mail at [email protected] and we can set up a time to chat.

@stale
Copy link

stale bot commented Jul 30, 2021

This discussion has been automatically marked as stale because it has not had recent activity. It will be closed in 60 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2021
@stale
Copy link

stale bot commented Sep 29, 2021

This discussion has been closed due to inactivity. Discussions can always be reopened after they have been closed.

@stale stale bot closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants