Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Put an empty/whitespace string in SpeechRecognitionKeyword break the whole speech system #612

Closed
anonymous2585 opened this issue Jan 11, 2024 · 0 comments · Fixed by #614
Closed

[BUG] Put an empty/whitespace string in SpeechRecognitionKeyword break the whole speech system #612

anonymous2585 opened this issue Jan 11, 2024 · 0 comments · Fixed by #614
Labels
Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@anonymous2585
Copy link
Contributor

anonymous2585 commented Jan 11, 2024 •
edited
Loading

Describe the bug

If a user or a script set the SpeechRecognitionKeyword on a StatefulInteractable to an empty/whitespace string (and AllowSelectByVoice is still true), the whole speech system stops recognizint keywords, without any warning or error.

If you have a script (in my case a LocalizedStringEvent for Unity Localization package) that briefly set an empty string and then set the correct string, the bug still remains and speech won't work at all.

To reproduce

Steps to reproduce the behavior:

  1. Open the CanvasExemple scene
  2. Choose one button and set the SpeechRecognitionKeyword to an empty field
  3. Build & Run on Hololens
  4. Look at another button, say "select" and see nothing happen

Expected behavior

If one button SpeechRecognitionKeyword is set to an empty string, other buttons still work.

Your setup

  • Unity Version: 2021.3.21f1
  • MRTK Version or Commit: current main branch 3707957

Target platform

  • HoloLens 2

Additional context

The issue is that the SpeechInteractor allows to register interactable with an empty string put in the keywordDictionary and then the Unity KeywordRecognizer doesn't work.
@anonymous2585 anonymous2585 added Needs: Triage Needs to be triaged. Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Jan 11, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jan 11, 2024
Fix empty SpeechRecognitionKeyword breaking all speech keyword system (…
0f447b1 
…MixedRealityToolkit#612)
@anonymous2585 anonymous2585 changed the title [BUG] Put an empty string in SpeechRecognitionKeyword break the whole speech system [BUG] Put an empty/whitespace string in SpeechRecognitionKeyword break the whole speech system Jan 11, 2024
@anonymous2585 anonymous2585 mentioned this issue Jan 11, 2024
Merged
@shaynie shaynie added Package: Input The Project input package is impacted by this issue. and removed Needs: Triage Needs to be triaged. labels Jan 11, 2024
shaynie added a commit that referenced this issue Jan 12, 2024
@anonymous2585 @shaynie
Fix empty SpeechRecognitionKeyword breaking all speech keyword system (…
d9ff8b0 
…#612) (#614)

Co-authored-by: Anonymous <[email protected]>
Co-authored-by: Scott Haynie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Milestone
No milestone
2 participants
@shaynie @anonymous2585