Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store normalized vnodes in the dom element. Add render tests. #2266

Merged
merged 2 commits into from
Oct 28, 2018
Merged

Store normalized vnodes in the dom element. Add render tests. #2266

merged 2 commits into from
Oct 28, 2018

Conversation

spacejack
Copy link
Contributor

@spacejack spacejack commented Oct 28, 2018 •
edited by dead-claudia
Loading

Description

Ensures that vnodes are normalized before being stored in the dom element (in m.render()).

Motivation and Context

Fixes #2264

How Has This Been Tested?

Existing tests pass, added tests to cover this case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@spacejack spacejack requested a review from pygy as a code owner October 28, 2018 20:59
dead-claudia
dead-claudia requested changes Oct 28, 2018
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry.

@dead-claudia dead-claudia merged commit ea0ce7f into MithrilJS:next Oct 28, 2018
@spacejack spacejack deleted the store-normalized-vnodes branch October 29, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

@barneycarroll barneycarroll barneycarroll approved these changes

@pygy pygy Awaiting requested review from pygy

Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(v2.0.0-rc.0) m.render throws an error when replacing plain text
3 participants
@spacejack @barneycarroll @dead-claudia