Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mikeyb patch 1 #2104

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Mikeyb patch 1 #2104

merged 2 commits into from
Mar 12, 2018

Conversation

mikeyb
Copy link
Contributor

@mikeyb mikeyb commented Mar 12, 2018

Added missing parenthese to reduce confusiion.

Description

Added single ) in docs

Motivation and Context

Saw problem, submitted fix

How Has This Been Tested?

Preview ### How it works

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@mikeyb mikeyb requested a review from tivac as a code owner March 12, 2018 22:27
@tivac tivac merged commit 23ebe2f into MithrilJS:next Mar 12, 2018
@tivac
Copy link
Contributor

tivac commented Mar 12, 2018

Thanks @mikeyb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tivac tivac Awaiting requested review from tivac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeyb @tivac