Small optimization in render hyperscript.js #2064

magikstm · 2017-12-30T10:05:36Z

Description

No functional change. I read code and noticed it.

Motivation and Context

Minor. Feel free to pull or not.

How Has This Been Tested?

Locally.

Types of changes

Optimization.

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have updated docs/change-log.md

Gandalf-the-Bot · 2017-12-30T10:07:04Z

	Warnings
⚠️	Please add an entry to docs/change-log.md.

Generated by 🚫 dangerJS

dead-claudia

LGTM mod a small nit

dead-claudia · 2017-12-30T10:24:09Z

render/hyperscript.js

@@ -108,6 +104,7 @@ function hyperscript(selector) {
 	var normalized = Vnode.normalizeChildren(children)

 	if (typeof selector === "string") {
+		var cached = selectorCache[selector] || compileSelector(selector)


Mind combining this with the next line, to save a temporary variable? (Your patch is more so optimizing space than speed, BTW.)

Squashed commits: [5b10329] Small optimization in render hyperscript.js

…magikstm/mithril.js into render-hyperscript-small-update

magikstm · 2017-12-30T20:44:47Z

Thanks for the review. I adjusted it.

I'm having trouble to squash commits in github with the command-line tools or SourceTree. :(

pygy · 2017-12-30T22:20:47Z

@magikstm The "Sloppy mode" comment was paired with the line you moved. I don't even remember why it's there (I used to, I thought I had made it more meaningful but that PR was probably not merged).

dead-claudia · 2017-12-30T22:29:14Z

@pygy The sloppy mode comment was for when the bundler hadn't yet been patched to emit strict mode bundles instead. Also, since we no longer support IE9 in `next` (MS dropped support with Vista), we can safely assume all browsers interpret strict mode directives correctly. So dropping it is of no concern anymore. (I'm the one who wrote that patch to repair sloppy mode use, BTW.)

…

On Sat, Dec 30, 2017, 17:20 Pierre-Yves Gérardy ***@***.***> wrote: @magikstm <https://github.com/magikstm> The "Sloppy mode" comment was paired with the line you moved. I don't even remember why it's there (I used to, I thought I had made it more meaningful but that PR was probably not merged). — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2064 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AERrBIxHg3nVjcQyAf5wImIQBbugunqVks5tFrdCgaJpZM4RPkCs> .

magikstm · 2017-12-30T22:35:26Z

Thanks. I just removed the comment.

dead-claudia · 2017-12-30T23:28:50Z

@magikstm If you're okay working from the CLI, there's git log to display info about commits, and git rebase ${ref} -i/git rebase ${ref} --interactive to interactively modify the history. I do that quite frequently when working with patch sets to trim the commits down to something a little more logical and workable.

pygy · 2017-12-31T00:11:00Z

@isiahmeadows I'm not against dropping IE 9 (and 10) support, given how marginal it has become, but I didn't know this was planned.

OTOH given the onpopstate bugs in IE 11 (IIRC) I'm not sure it buys us much.

magikstm · 2017-12-31T00:16:13Z

@isiahmeadows I'm unfortunately a bit limited with the Git CLI. I use it a bit, but usually use SourceTree. I'm not that used to squashing commits. It's a feature of Git I have to learn more.

Could you do it before a merge or after it?

dead-claudia · 2017-12-31T03:16:21Z

@pygy MS dropped it with Vista, which EOL'd this year IIRC. We usually don't bother supporting obscure (e.g. IE7 for Windows POS Ready) or manufacturer-unsupported operating systems, and that's also why we dropped IE 6-8 support for 1.x. Windows 7 isn't EOL until 2020, so it's going to be a while before that hits. @magikstm Don't worry too much about the history - some of our own PRs have been a bit messy history-wise. ;-)

…

On Sat, Dec 30, 2017, 19:16 magikstm ***@***.***> wrote: @isiahmeadows <https://github.com/isiahmeadows> I'm unfortunately a bit limited with the Git CLI. I use it a bit, but usually use SourceTree. I'm not that used to squashing commits. It's a feature of Git I have to learn more. Could you do it before a merge or after it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2064 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AERrBBJfVQUTtnLC_K6m7N99YjcsUL09ks5tFtJQgaJpZM4RPkCs> .

barneycarroll

This is much nicer IMO 👍

pygy · 2018-05-18T18:49:06Z

Here we go!

Thanks @magikstm

* Do not normalise component children on ingestion * Don't normalise vnode children * Component hyperscript tests: children aren't normalised * test, not text * Update change log: #2155 & #2064

* Small optimization in render hyperscript.js * Remove temporary variable * Small optimization in render hyperscript.js Squashed commits: [5b10329] Small optimization in render hyperscript.js * Remove sloppy mode comment

Small optimization in render hyperscript.js

5b10329

magikstm requested review from dead-claudia and pygy as code owners December 30, 2017 10:05

dead-claudia requested changes Dec 30, 2017

View reviewed changes

magikstm added 3 commits December 30, 2017 15:06

Remove temporary variable

fcea176

Small optimization in render hyperscript.js

b64acd9

Squashed commits: [5b10329] Small optimization in render hyperscript.js

Merge branch 'render-hyperscript-small-update' of https://github.com/…

8eea2c5

…magikstm/mithril.js into render-hyperscript-small-update

Remove sloppy mode comment

1cbecd8

barneycarroll approved these changes May 18, 2018

View reviewed changes

pygy merged commit 6097cfb into MithrilJS:next May 18, 2018

pygy mentioned this pull request May 18, 2018

Do not normalise component children on ingestion #2155

Merged

10 tasks

barneycarroll added a commit that referenced this pull request May 29, 2018

Update change log: #2155 & #2064

7967ddd

dead-claudia added the backport to v1 label Sep 1, 2018

dead-claudia mentioned this pull request Oct 9, 2018

Backport all the non-breaking bug fixes from v2 into v1.2 #2243

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small optimization in render hyperscript.js #2064

Small optimization in render hyperscript.js #2064

magikstm commented Dec 30, 2017

Gandalf-the-Bot commented Dec 30, 2017 •

edited

Loading

dead-claudia left a comment

dead-claudia Dec 30, 2017

magikstm commented Dec 30, 2017

pygy commented Dec 30, 2017

dead-claudia commented Dec 30, 2017 via email

magikstm commented Dec 30, 2017

dead-claudia commented Dec 30, 2017

pygy commented Dec 31, 2017

magikstm commented Dec 31, 2017

dead-claudia commented Dec 31, 2017 via email

barneycarroll left a comment

pygy commented May 18, 2018 •

edited

Loading

Small optimization in render hyperscript.js #2064

Small optimization in render hyperscript.js #2064

Conversation

magikstm commented Dec 30, 2017

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Gandalf-the-Bot commented Dec 30, 2017 • edited Loading

dead-claudia left a comment

Choose a reason for hiding this comment

dead-claudia Dec 30, 2017

Choose a reason for hiding this comment

magikstm commented Dec 30, 2017

pygy commented Dec 30, 2017

dead-claudia commented Dec 30, 2017 via email

magikstm commented Dec 30, 2017

dead-claudia commented Dec 30, 2017

pygy commented Dec 31, 2017

magikstm commented Dec 31, 2017

dead-claudia commented Dec 31, 2017 via email

barneycarroll left a comment

Choose a reason for hiding this comment

pygy commented May 18, 2018 • edited Loading

Gandalf-the-Bot commented Dec 30, 2017 •

edited

Loading

pygy commented May 18, 2018 •

edited

Loading