[WIP, don't merge] Fix #1804 and tweak #1595 #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: #1862 is now merged. |
This was referenced Jun 1, 2017
8 tasks
|
@pygy Ping...how close to ready is this to merge (another PR might be blocked on this)? |
|
@vasilrimar reported issues where passing |
10 tasks
tivac
approved these changes
May 31, 2018
dead-claudia
reviewed
Jun 1, 2018
render/render.js
Outdated
| if(attrs.value === null) { | ||
| if (vnode.dom.selectedIndex !== -1) vnode.dom.value = null | ||
| } else { | ||
| /*eslint-disable no-implicit-coercion*/ |
There was a problem hiding this comment.
Have you tried // eslint-disable-next-line no-implicit-coercion?
There was a problem hiding this comment.
Good point. I went for // eslint-disable-line since it is what we use the most, and normalized the way we use those directives in the code base.
dead-claudia
approved these changes
Jun 1, 2018
before: > mutate styles/properties x 7,999 ops/sec ±10.87% (46 runs sampled) after: > mutate styles/properties x 16,104 ops/sec ±4.36% (66 runs sampled)
|
Thanks @isiahmeadows the review is most welcome :-) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1804 and tweaks #1595.
removeAttr()now mirrorssetAttr(). values set toundefinedornullare equivalent to a lack of value, except forselect, wherenullThere are still possibly problematic corner cases with
select.value, please don't merge this yet.#1862 can be merged as is in the mean time if you want. I'll rebase this.