Ritual of Locating only works for Biomes

[Slickson77]

Describe the bug
Trying to create a Thaumaturgic Compass for anything that is a structure will have the ritual fail immediately with a message that "The Ritual wasn't able to find it's target within a reasonable distance"

To Reproduce
Steps to reproduce the behavior:

1. Perform the ritual of location using ANY structure Thaumaturgic Link
2. See error

Expected behavior
man ... I'd like to be able to find structures using the magic compass

Version Information (please complete the following information):

• Mod Version: [1.20.1-3.0.0.15-all]
• Forge Version [47.2.20]

Additional context
My guess is that this broke when you ported from 1.18.2. The older version had one locate command for both biomes and structures (I think). In 1.20.1 this was switched so that biomes use "/locate biome" and structures use "/locate structure".

[Mithion]

Just tried it in dev, worked fine. Several times in a row, using different structures, both modded and non. Nothing broke in the update.

I attempted a minor change in methodology when resolving the holder set, which still finds structures in my dev instance so maybe it will work for this now too. Honestly I haven't seen this at all yet. No idea why it isn't working. We'll see if next update is any better.

[Slickson77]

No idea if this helps at all ... but in my line of work, more info is always better!

MoM server crashed while running a locate ritual for a biome after initiation in about 5-10 sec. I was the only one on the server at the moment.
crash-2024-06-28_11.08.30-server.txt

Vallen was able to log in and run a command manually without issue

[Slickson77]

Latest release of MnA mna-forge-1.20.1-3.0.0.18-all.jar

When it rains it pours. I got good news and bad news

1. The biome links and Structure links still have the same texture in the wizards UI and after purchasing
   Left is Minecaft:Desert_temple, right is Minecraft:Desert

2. Single player world
   Structure locating works ... and it was surprisingly faster than the locate command
   Biome locating works ... and this took maybe three times longer than the command

3. Local Server
   Ritual of locating (for Biome) on a server times out and causes a crash
   crash-2024-07-08_11.57.26-server.txt
   Ritual of locating (for Structure) on a server times out and causes a crash
   crash-2024-07-08_12.09.43-server.txt

[Slickson77]

After staring at the picture AFTER posting .. i see the slight but barely noticeable difference. Red dots .... just a personal opinion ... most people won't notice that detail :)

[Slickson77]

Just tried this on local server with mna-forge-1.20.1-3.0.0.19-all

Structure actually worked! ... I think it was because the structure was under 500 blocks. Anything over that and the server ticks take to long and the server assumes it's crashed. I have no idea if this can be solved or not, maybe a server setting somewhere, I'll have to research more.

LatestLog before crash

[09Jul2024 06:36:59.462] [Server thread/INFO] [net.minecraft.server.commands.LocateCommand/]: Locating element minecraft:desert took 19851 ms
[09Jul2024 06:36:59.465] [Server thread/WARN] [net.minecraft.server.MinecraftServer/]: Can't keep up! Is the server overloaded? Running 19865ms or 397 ticks behind
[09Jul2024 06:38:55.434] [Server thread/INFO] [ModernFix/]: Instantiating Mojang DFU
[09Jul2024 06:38:58.790] [Server thread/INFO] [net.minecraft.server.commands.LocateCommand/]: Locating element awesomedungeon:abandoned_oak_palace took 6824 ms
[09Jul2024 06:38:58.791] [Server thread/WARN] [net.minecraft.server.MinecraftServer/]: Can't keep up! Is the server overloaded? Running 6793ms or 135 ticks behind
[09Jul2024 06:39:41.568] [Server thread/WARN] [net.minecraft.server.MinecraftServer/]: Can't keep up! Is the server overloaded? Running 3870ms or 77 ticks behind
[09Jul2024 06:42:04.999] [Server Watchdog/ERROR] [net.minecraft.server.dedicated.ServerWatchdog/FATAL]: A single server tick took 60.00 seconds (should be max 0.05)
[09Jul2024 06:42:04.999] [Server Watchdog/ERROR] [net.minecraft.server.dedicated.ServerWatchdog/FATAL]: Considering it to be crashed, server will forcibly shutdown.
[09Jul2024 06:42:05.835] [Server Watchdog/FATAL] [net.minecraftforge.common.ForgeMod/]: Preparing crash report with UUID 79527b0e-b7e0-4cc3-a764-1f89451de2fb
[09Jul2024 06:42:05.907] [Server Watchdog/FATAL] [net.minecraftforge.common.ForgeMod/]: Preparing crash report with UUID 97788c28-6971-4ebe-a967-116e11a22c6a
[09Jul2024 06:42:05.915] [Server Watchdog/ERROR] [net.minecraft.server.dedicated.ServerWatchdog/]: This crash report has been saved to: ForgeSlickMine\WellSpring Adventures 2 - 1_24ServerPack.\crash-reports\crash-2024-07-09_06.42.05-server.txt

[Mithion]

Well, at least it's progress. I'll probably need to multithread this somehow. I was hoping for a less complicated solution. Thanks for all your hard work in providing me this much context and information about the issue. I really appreciate it.

[christofferson]

+1 to the crash on servers with version 1.20.1-3.0.0.21. Server is also using Terralith, severely modifying worldgen and potentially causing the desired biome to be several thousand blocks away. Crash report omitted as it's functionally identical to what was previously provided

[Slickson77]

Maybe you can check out the source code for these mods.

https://www.curseforge.com/minecraft/mc-mods/natures-compass

https://www.curseforge.com/minecraft/mc-mods/explorers-compass