Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Freezes when Opening Certain Menus #781

Open
Cropfire opened this issue May 10, 2024 · 0 comments
Open

Client Freezes when Opening Certain Menus #781

Cropfire opened this issue May 10, 2024 · 0 comments
Labels
Investigating Looking into this. Not yet confirmed to be a bug/on M&A's end.

Comments

@Cropfire
Copy link

There are a few GUIs that momentarily freeze the game when initializing. These are mainly the Book of Rote, Codex Arcana, and the Scribing Table. The Codex Arcana only freezes the game the first time it is opened but the other two freeze for about 2-5 seconds each time they are opened.

Running the Spark client profiler when opening the Book of Rote (and also using its search function which freezes the game as well) led me to these:

net.minecraft.world.item.crafting.RecipeManager.getRecipes()
-> java.util.stream.ReferencePipeline.collect() (takes about 2 seconds)
java.util.stream.ReferencePipeline.findFirst() (takes about 2 seconds)

Which seems to be when validParts is called during the reInit function in the SpellPartsList file.

This is also with quite a hefty mod list and reducing the mods (and by extension the recipe amount) seems to help a little but still causes lag unless there's a very small amount of mods. Here is the pastebin:

https://pastebin.com/heM9xxRh

Steps to reproduce the behavior:

  1. Get item 'Book of Rote' or 'Codex Arcana'
  2. Open the Spell Menu
  3. Notice Lag

Version Information (please complete the following information):

  • Mod Version: mna-forge-1.20.1-3.0.0.14-all
  • Forge Version: 1.21.1-forge-47.2.30
@Mithion Mithion added Investigating Looking into this. Not yet confirmed to be a bug/on M&A's end. 1.20 labels May 13, 2024
@Mithion Mithion moved this from To triage to Backlog in M&A 1.20 Bug Tracking Jul 22, 2024
@Mithion Mithion removed the 1.20 label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating Looking into this. Not yet confirmed to be a bug/on M&A's end.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants