Suggestion: Visual cue to indicate failure to open a block locked by runes

[Mithion]

Currently there is no clue to indicate that a block with a UI is locked by a keystone when you try to open it. Nothing happens.

This could be interpreted as a bug or something not functioning properly.

A few suggestions are a particle effect, a chat message, or a sound.

[DoomFruit]

Sure, I'll get on that. My initial approach would be to change the canPlayerAccess() function in KeystoneUtilities.java, adding a third parameter which basically says "break", "use" or "none", so that it doesn't trigger if you're just testing for access or that you get a different message/effect if you try to break it. This means changing everything which uses this function, but it'll be easier to maintain in the future.

I'll go with a chat message for now, but it should be pretty easy to swap it out later on if desired by changing the canPlayerAccess function from sending chat messages to spawning particles or whatever.

[DoomFruit]

OK, done. I've put the same functionality into the dig spell fix branch and also into a separate one which was freshly forked from the master branch (in case there are still unresolved issues with the dig spell/particle emitter fix code). Currently, it prints a message to the player's chat bar, saying "you do not have the right keystone to use/break this block", but this can be changed in KeystoneUtilities.java. Note that the separate branch does not incorporate any of the fixes made while testing the dig spell, so don't be surprised if you're still able to break rune-locked keystone chests (for instance).

While testing, I also found out that the armour imbuement table was listed as having keystone functionality, but it only had 4 inventory slots (one for each armour piece) and no space in the GUI for a keystone combination. I commented out the keystone parts there.

[irkedIsaac]

I personally think it would be sort of funny for them to get punched by it. Just imagine you reach for a door and oH GOD IT KNOCKED ME BACK OKAY I DON'T BELONG HERE.

Maybe in the case of spell-locked doors, the spell you try might rebound? I dunno, I just think that would be cool.