[v1.4.0.008] Bug with Appropriation in Water (and with some blocks)

[archdruid]

I found some older (Feb) problems that were answered by Mithion to be fixed in the dev release, so these might be also already found and fixed as of that one, might not be. They are similar to the ones posted #1089 and #1063.

---

General message that appears: Something went wrong restoring the block. This spell was probably created with older version (not true in this case) and the block has been deleted and the spell should work moving forward.

---

Ok, the issues found:

When using Appropriation (projectile) on stairs, stone bricks, bricks, or blocks from other mods in general (tested with Blood magic runes, rubber wood (both mods), Thaumcraft silverwood, machines from Factory Reloaded or pretty much any blocks from other mods), they will fail to reappear on second cast, displaying the "General message" above. There are probably others that have this basic failure from vanilla blocks as well.

When using Appropriation on cobblestone, the cobblestone would be replaced by stone bricks on second cast.

The weirdest set of problems came from using the spell with water, possibly other liquids as well:

-When casting spell (from out of water or inside) into water, one can grab mobs and blocks without problems.
-However, one can't place any blocks or mobs into water-the spell hits, gives magic xp, and then doesn't have the block/mob shown (and the block/mob will stay there in the spell, and will appear in the first subsequent instance you cast it into a non-liquid).

[davetheknave]

In my experience, it does this with any block that has damage values. For instance, it will fail with wool, because it uses the damage values to store the information about what color it is. Wood is the same, because it uses that information for rotation and species of tree.

[chrisfand]

Can confirm issue described by OP. One thing I noticed is that Appropriation spell will not put the block into a space that has a liquid source block.