Replace KeyboardEvent.key → KeyboardEvent.code wherever possible
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible Turns out .key returns the actual key the user would have sent on an input. This means if the user was pressing shift + S, then `.key` would be `"S"`. If the user wasn't pressing Shift, then `.key` would be `"s"`. Makes the compile keybind work again.
Mitcheljager
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
.keyreturns the text the user would have typed on a text input.For example, if the user was pressing Shift + S, then
.keywould be"S". If the user wasn't pressing Shift, then.keywould be"s".This makes the Compile keybind work again.