Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with xargs anymore #489

Closed
maltsev opened this issue May 24, 2021 · 4 comments · Fixed by #874
Closed

Doesn't work with xargs anymore #489

maltsev opened this issue May 24, 2021 · 4 comments · Fixed by #874
Assignees
Labels
blocked This issue is blocked by some other issue bug macOS

Comments

@maltsev
Copy link

maltsev commented May 24, 2021

Hey,

I'm using your tool for a couple of years now. It's great and helps me a lot in my work. Thanks!

Recently I have noticed that one of my rebase commands has stopped working:

echo $COMMIT_HASH | xargs -o git rebase --interactive

After I run it, the terminal window starts to constantly rerender (multiple times per second) and didn't react to key presses at all. So I have to kill it. I tested it both in the default Terminal.app and iTerm2. I'm using macOS 11.3.1.

Not sure if it's directly related to xargs or something else. Let me know if you need me to provide more info or check something else.

@MitMaro MitMaro added bug investigate Requires investigation labels May 24, 2021
@MitMaro MitMaro self-assigned this May 24, 2021
@MitMaro
Copy link
Owner

MitMaro commented May 25, 2021

Thanks for the report!

This is interesting. I just gave a test on Linux, but it doesn't seem to happen there. It's probably a macOS specific bug, which are always a pain.

That the tool is constantly rendering and ignoring your key presses, leads me to believe there is something happening with the input handling. As a render is only triggered where there is some sort of input.

I will take a look this week when I am back on a Mac.

@MitMaro
Copy link
Owner

MitMaro commented May 30, 2021

I looked into the problem, and it seems that this is an upstream issue that is currently blocked by another upstream issue.

With the latest release, this project started to use Crossterm to address some issues with Windows. While this brought in several advantages for all operating systems, it sadly broke support for TTY redirection on macOS.

I will keep this issue open to track the upstream issue, and hopefully in the future this can be fixed. Sadly, the only advice I can give at the moment is to not use the pipe and xargs, which I know isn't really a satisfactory answer.

@MitMaro MitMaro added blocked This issue is blocked by some other issue macOS and removed investigate Requires investigation labels May 30, 2021
@MitMaro MitMaro moved this to Triage in GIRT Project Mar 26, 2022
@MitMaro MitMaro moved this from Triage to Backlog in GIRT Project Mar 26, 2022
@MitMaro
Copy link
Owner

MitMaro commented Jan 11, 2023

The upstream issue causing this to work may have been fixed. I need to update with the latest version of Crossterm and see if there are other changes that can be made, but 🤞🏼 .

@github-project-automation github-project-automation bot moved this from Backlog to Complete in GIRT Project Jul 21, 2023
@MitMaro
Copy link
Owner

MitMaro commented Jul 21, 2023

I've enabled the TTY support on macOS in the latest build, so the above use case should work again. Thanks for the report, and apologies it took so long to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by some other issue bug macOS
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants