-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'a' needed when checking what entity it is. #10
Comments
Hard to fix actually. When writing "if loop-entity is skeleton", Skript read that as "if loop-entity is the skeleton". Skript doesn't know who "the skeleton" is and it doesn't find the needed comparator because of that and fails to work. Therefore the "a" is needed before the "skeleton" to clarify it as a type not an object. I am not sure how to fix this at all. |
The expression By making "event" required it would probably fix this problem but it would break like every script in the community, so that doesn't seem like a option. |
Perhaps fixed without any problems. But it is possible for another issue/bug to appear because of my fix. Used the same "hack" I got from Njol's code in Issue #9 Needs more testers. |
Seems to add another issue/bug. A rather big one for current scripts. Example code which doesn't work:
Example code which works:
Basicly it's going the other way now. Now you have to prefix it with "event-" for it to work. This would break like every script. So I don't think this fix will work. I have even started to doubt that it is possible to fix this issue without making "event-" or "the" mandatory.
This solution seems like a nono. So it will not be added unless I fix this new bug. |
I found a new fix(could be called quickfix or a little trick) which works perfectly. Passed all my tests. Still can't guaruantee it's bugfree but it's unlikely to give birth to a new bug since the only code change is to the Compare condition (if entity is skeleton for example). |
Previous fix had a problem. It was a miss in my code so I have fixed it. But still there's some "issues" with this fix:
I made a quick check for this so my "quick" fix doesn't include the "player" so: This means in other events such as this(Check the broadcasts to see what I mean):
In the older version(2.1.2, 2.2 and my older versions) this works like:
This seems to be the best result of the fixes I have tried for this. Don't worry I stated high up in this comment that code involving comparing with players like:
Will work just fine! Either this "fix" or I will attempt to find another one or scrap this bug. |
Example: http://pastebin.com/Ppw0QqLB
The check doesn't work properly without the 'a'.
The text was updated successfully, but these errors were encountered: