-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ddragon & cdragon support #16
Comments
In my opinion we should make this a seperate package but we can still keep the code in the Camille repo. Something like:
For my personal project this would be useful. But giving back an Image would make more sense, as people could then easily save it to their disk to cache it and prevent hotlinking.
I would say no, since its static data, and there doesn't seem to be a harsh rate limit on the api. |
After thinking and experimenting with it, we should have the option for DataDragon to download the whole DragonTail tar from a specific patch, specified by an argument unpack it and then be able to load the json files and images through the library. So we won't rely on network IO for the most part, since its all static data anyway this will only cost roughly 1.56GB per patch due to the massive amount of images present in the DragonTail tar. |
Seems like we shouldn't reuse the Riot API regional requester, which has a lot of focus on rate limiting? So this will be a standalone lib, mainly providing DTO class generation and method-to-file/url mappings? Similar for #24 (LCU), though rate limiting is needed there, it can just be simpler |
Sounds good to me |
There are at least two different data dragons nowadays, one for League of Legends and one for Legends of Runeterra. So... |
I've been looking through a few of the related issues and am just confirming.. Is this still not supported? Thanks for the info, cheers! |
@lorenblue Correct, it is not implemented |
https://cdn.communitydragon.org/latest/champion/Zyra/data (seems cdragon only is en_US)
Questions:
byte[]
or something) or is that not useful? (hotlinking to ddragon is discouraged, but hotlinking to cdragon is fine)The text was updated successfully, but these errors were encountered: