Don't send data to other servers if syncing option is disabled #7
Labels
Comments
|
What exactly is your goal here? (Also the Also can you please all of the missing information which the issue template requests? |
Used Versionserver_a: SyncInv v0.6-SNAPSHOT (build 64) Configserver_a: # Debugging mode to log more about what's going on
debug: true
# Redis messenger settings
redis:
host: localhost
port: 19999
timeout: 60
password: ##############
# you can also directly set the uri for example like this (directly set values overwrite uri parameter 'though):
# uri: redis://password1@localhost:6379/database?timeout=60s [&database=database]
# Whether or not the plugin should query inventories on other server
# or just move the player to the server with the newest inventory
query-inventories: true
# The name of the group this server is in. Set that to the same value
# on all servers which's data you want to get synced.
server-group: enviroment_test
# The name of this server. If you don't want to query inventories then
# this has to be the same as the name in your BungeeCord's config.yml
server-name: test_a # CHANGE THIS!
# A list of server names that are required to answer to request
# That way you can stop issues when a server isn't online that usually should be
required-servers: []
# - server2
# - server3
# Whether or not we should sync the data with all servers in a group
# when a player logs out. Use this if your servers have the tendency
# to not always be online.
sync-with-group-on-logout: true
# Store player data even if the player never joined the server
# This will create a player.dat when the data is synced and most likely
# breaks first join detection of other plugins
store-unknown-players: true
# The amount of seconds we should maximally wait for all servers to
# respond to a query
query-timeout: 5
# Whether or not we should load the data from queries that timed out
# This might run into issues if the server with the most recent data
# is not online at the moment of querying!
# It will basically disable the required-servers function
apply-timed-out-queries: false
# What to sync
sync:
# Should the plugin sync player inventory items?
inventory: true
# Should the plugin sync player enderchest items?
enderchest: true
# Should the plugin try sync the player gamemode? (Only works when the player is actually online, not for offline storage)
gamemode: true
# Should the plugin sync the player experience?
experience: true
# Should the plugin sync the player's health, max health and health scaling?
health: true
# Should the plugin to sync the player's food level?
hunger: true
# Should the plugin to sync the player's saturation?
saturation: true
# Should the plugin to sync the player's exhaustion?
exhaustion: true
# Should the plugin to sync the player's air level?
air: true
# Should the plugin sync the player's on fire state and fire duration?
fire: true
# Should the plugin to sync the player's no-damage-ticks?
no-damage-ticks: true
# Should the plugin to sync the player's current velocity?
velocity: true
# Should the plugin sync the player's current fall distance?
# (Might kill player on other server when log in on the ground)
fall-distance: true
# Should the plugin try to sync player effects? (Only works when the player is actually online, not for offline storage)
effects: true
# Should the plugin try to sync persistent nbt data on the player object?
persistent-data: true
# Should the plugin sync player advancement progress?
advancements: true
# Should the plugin sync general player statistics?
general-statistics: true
# Should the plugin sync entity player statistics?
entity-statistics: true
# Should the plugin sync item player statistics?
item-statistics: true
# Should the plugin sync block player statistics?
block-statistics: true
# Should the plugin try to keep maps in sync?
maps: true
# Language settings
lang:
cant-pickup-exp: "&cYou can only collect EXP once your player data is loaded!"
cant-pickup-items: "&cYou can only collect items once your player data is loaded!"
cant-drop-items: "&cYou can only drop items once your player data is loaded!"
cant-move: "&cYou can only move once your player data is loaded!"
wait-for-loading: "&cPlease wait until your player data is loaded!"
cant-load-data: "&cSorry but the server wasn't able to load your latest player data.\nPlease contact an administrator if this happens often!"
server_b: # Debugging mode to log more about what's going on
debug: true
# Redis messenger settings
redis:
host: localhost
port: 19999
timeout: 60
password: ##############
# you can also directly set the uri for example like this (directly set values overwrite uri parameter 'though):
# uri: redis://password1@localhost:6379/database?timeout=60s [&database=database]
# Whether or not the plugin should query inventories on other server
# or just move the player to the server with the newest inventory
query-inventories: true
# The name of the group this server is in. Set that to the same value
# on all servers which's data you want to get synced.
server-group: enviroment_test
# The name of this server. If you don't want to query inventories then
# this has to be the same as the name in your BungeeCord's config.yml
server-name: test_b # CHANGE THIS!
# A list of server names that are required to answer to request
# That way you can stop issues when a server isn't online that usually should be
required-servers: []
# - server2
# - server3
# Whether or not we should sync the data with all servers in a group
# when a player logs out. Use this if your servers have the tendency
# to not always be online.
sync-with-group-on-logout: true
# Store player data even if the player never joined the server
# This will create a player.dat when the data is synced and most likely
# breaks first join detection of other plugins
store-unknown-players: true
# The amount of seconds we should maximally wait for all servers to
# respond to a query
query-timeout: 5
# Whether or not we should load the data from queries that timed out
# This might run into issues if the server with the most recent data
# is not online at the moment of querying!
# It will basically disable the required-servers function
apply-timed-out-queries: false
# What to sync
sync:
# Should the plugin sync player inventory items?
inventory: false
# Should the plugin sync player enderchest items?
enderchest: false
# Should the plugin try sync the player gamemode? (Only works when the player is actually online, not for offline storage)
gamemode: false
# Should the plugin sync the player experience?
experience: true
# Should the plugin sync the player's health, max health and health scaling?
health: true
# Should the plugin to sync the player's food level?
hunger: true
# Should the plugin to sync the player's saturation?
saturation: true
# Should the plugin to sync the player's exhaustion?
exhaustion: true
# Should the plugin to sync the player's air level?
air: true
# Should the plugin sync the player's on fire state and fire duration?
fire: true
# Should the plugin to sync the player's no-damage-ticks?
no-damage-ticks: true
# Should the plugin to sync the player's current velocity?
velocity: true
# Should the plugin sync the player's current fall distance?
# (Might kill player on other server when log in on the ground)
fall-distance: true
# Should the plugin try to sync player effects? (Only works when the player is actually online, not for offline storage)
effects: true
# Should the plugin try to sync persistent nbt data on the player object?
persistent-data: true
# Should the plugin sync player advancement progress?
advancements: true
# Should the plugin sync general player statistics?
general-statistics: true
# Should the plugin sync entity player statistics?
entity-statistics: true
# Should the plugin sync item player statistics?
item-statistics: true
# Should the plugin sync block player statistics?
block-statistics: true
# Should the plugin try to keep maps in sync?
maps: true
# Language settings
lang:
cant-pickup-exp: "&cYou can only collect EXP once your player data is loaded!"
cant-pickup-items: "&cYou can only collect items once your player data is loaded!"
cant-drop-items: "&cYou can only drop items once your player data is loaded!"
cant-move: "&cYou can only move once your player data is loaded!"
wait-for-loading: "&cPlease wait until your player data is loaded!"
cant-load-data: "&cSorry but the server wasn't able to load your latest player data.\nPlease contact an administrator if this happens often!"
N/A Full Logserver_a: What other programs/plugins are you running?server_a: server_b: What is happening?Server a: Server A: (64 Diamonds) -> Teleport to Server B -> Diamonds are not sync. Thats okay. Expected behaviour. So it the signal SHOULDN’T be sent or received when it set to false. What did you expect to happen?Server A represents a survival server. We don't want to share inventory between Additional context |
|
The config options define whether or not the server with the config will apply those values, not if they get sent. The original design follows the concept of those options being in sync in the whole group so this is more of a feature request than an actual bug. (The options were named in the vain of "syncing data from other servers", not "syncing to other servers" although that's not made explicitly clear) Implementing this functionality will require an internal rework of how the syncing data is gathered and sent :S |
Phoenix616
changed the title
The current implementation is simple and works just fine as long as the options are the same everywhere. A one way sync was never meant to be supported by this plugin nor requested at any point before. |
Two-way synchronisation would make more sense for this type of plugin. In fact that's what one naturally interprets when looking at the "true" or "false" options. Perhaps you could add a toggleable option to set the sync direction. You are a good programmer, I trust you can do a good job. The plugin itself is already an excellent solution, it just needs this one big change. |
|
Hello, when might we hear about this change? It would be necessary to be able to test it in production with players. |
|
Any news? |
Once this change was made this issue will be closed. |
Okey, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi. I have a mini-game server where I don't want the inventory to be shared with the survival server, for security reasons.
By setting
sync.inventory: false,sync.enderchest: falseandsync.gamemode: falsethe inventories are still shared. I have tried the optionssync-with-group-on-logout: falseandquery-inventories: falseand I don't get results either.In fact I have tried setting all
syncoptions to false exceptsync.persistent-data: trueand the result is still the same: inventories are shared between servers.What could I be doing wrong? Maybe I'm misinterpreting the plugin options?
SyncInv/config.yml
The text was updated successfully, but these errors were encountered: