Change UInt instances to Int #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclima93
force-pushed
the
enhancement/prefer-signed-integers-over-unsigned-integers
branch
2 times, most recently
from
dee897a to
2e38944
Compare
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 96 96
Lines 3264 3264
=======================================
Hits 3099 3099
Misses 165 165
Continue to review full report at Codecov.
|
aclima93
changed the title
aclima93
requested review from
p4checo,
filipe-lemos and
a team
and removed request for
p4checo and
filipe-lemos
Use the recommended rule-of-thumb on the [official documentation](https://docs.swift.org/swift-book/LanguageGuide/TheBasics.html#//apple_ref/doc/uid/TP40014097-CH5-XID_411) and use signed integers.
aclima93
force-pushed
the
enhancement/prefer-signed-integers-over-unsigned-integers
branch
from
2e38944 to
a84efaf
Compare
filipe-lemos
approved these changes
May 27, 2021
aclima93
deleted the
enhancement/prefer-signed-integers-over-unsigned-integers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Use the recommended rule-of-thumb on the official documentation and use signed integers instead of unsigned integers.
Description
There aren't many instances of
UInt, and the majority of them can be repurposed as signed integers, namely the instances related with Persistence, Logger and Token.The only exceptions seem to be
XCT[Fail|AssertEqual|etc.]methods that use line numbers as a parameterUIColorhexcode methodsDataSPKI SHA256 Base64 encoded hashes