-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL query for a specific block (within transition frontier) #7404
Comments
implementation cost is 5min + overhead of landing a PR Near zero risk of introducing any regressions |
Please don't forget to add the following input: and following output totalCount these fields would help front-end work easily. |
@crackerli this endpoint is always limited to returning a list of at most size 290 (pending small changes to consensus constants). As such I think the paging system isn’t necessary. Before/after doesn’t add anything on top of height. relatedTo, first n, last n in bestChain. Should be easy enough to add though |
So, if the user has 291 transactions, he may can not see the earliest transaction? |
@crackerli it's 290 blocks. If the user's transactions happened outside of those 290 blocks you would have to get from somewhere else e.g. archive node. |
Thank you much, I understood |
@psteckler I perceive that this issue should be closed. Is that right? |
Yes, closing. |
We currently have a bestChain query that returns blocks on the best chain within the transition frontier but we don’t have a way to query for individual blocks via hash or height from this interface.
This is very very simple to add from an implementation perspective and is useful.
The text was updated successfully, but these errors were encountered: