Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Snark work to be broadcasted #5567

Closed
aneesharaines opened this issue Aug 4, 2020 · 3 comments
Closed

Batch Snark work to be broadcasted #5567

aneesharaines opened this issue Aug 4, 2020 · 3 comments
Assignees

Comments

@aneesharaines
Copy link
Contributor

aneesharaines commented Aug 4, 2020

A snark coordinator adds completed snark work to the pool and broadcasts as soon as it receives from a snark worker process. Each completed work is verified and broadcasted separately. When many snark workers are sending completed work to the coordinator at once, it is causing long async cycles of 90-140 seconds (seen in a testnet with 64 snark workers connecting to a coordinator). Waiting for some time to collect as many completed work before adding it to the pool will help leverage batch verification and will result in less messages to be gossiped.

@deepthiskumar
Copy link
Member

Currently, all the snark workers use the public key and fee set by the snark coordinator. When that changes to allow snark workers to have their own fee and public key, this would require the solution proposed in #4882

@aneesharaines
Copy link
Contributor Author

Will revisit for work outside of the verification if it seems like this is still a bottleneck

@emberian
Copy link
Contributor

emberian commented Feb 2, 2024

done by 2fa079d

@emberian emberian closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants