Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only a single RedirectRoute is persited when creating a RouteCollection #2035

Closed
jtothebell opened this issue Aug 15, 2024 · 1 comment
Closed

Comments

@jtothebell
Copy link
Contributor

First of all, thank you for this library. I have been using 5.0.4 for some time and it has served us well. I am in the process of updating my app from AutoRoute 5.0.4 to AutoRoute 9.2.1+1. In doing so I discovered that redirects were not behaving as they did in 5.0.4.

It appears that when creating a RouteCollection.fromList, only the last RedirectRoute from the list is persisted. This leads to unexpected redirects and lack of redirects in cases where multiple RedirectRoutes are intended to be used in an AppRouter. It looks like this is because AutoRoutes are added to a map keyed by their name and all RedirectRoutes share the same name.

I will be creating a PR to address this issue shortly. Thank you again.

@jtothebell
Copy link
Contributor Author

With the merge of #2036 and release of version 9.2.2, this is resolved. Thank you @Milad-Akarie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant