Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Port TencentARC/PhotoMaker #2478

Closed
huchenlei opened this issue Jan 15, 2024 · 15 comments
Closed

[DevTask] Port TencentARC/PhotoMaker #2478

huchenlei opened this issue Jan 15, 2024 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@huchenlei
Copy link
Collaborator

https://github.com/TencentARC/PhotoMaker released code. The mechanism is similar to ip-adapter with varitations on how input are preprocessed.

@2blackbar
Copy link

2blackbar commented Jan 16, 2024

Yeah but it accepts multiple images, which is something that IP adapters in auto11 controlnet should also accept and issue for that already exists but looks like nobody cares

IMO this needs to finally be addressed cause we can only feed one image in controlnet currently and that limits ipadapters useage cause they can accept multiple images at once in batch,

In comfy thanks to feeding multiple images with batch we can create instant lora, i just give it my folder path and it takes all iamges from that path in comfy to send to ipadapter.
Something like this would be very nice in auto11
So... how about we give it a path to images, or just choose multiple images in auto11 controlnet section for preprocessors that support multiple images

@huchenlei
Copy link
Collaborator Author

huchenlei commented Jan 16, 2024

Multiple IP-Adapters issue has been fixed. See #2472 @2blackbar. For now you just need to enable enough ControlNet units to handle multiple inputs.

Taking the whole directory probably need you work with API a bit.

@2blackbar
Copy link

Yes but that just 1 pic per controlnet which is not enough to do what comfyui does, the fix is appreciated tho cause i tried one pic per cnet and it wasnt working before , thanks.

@lhucklen
Copy link

Any word on support?

@hben35096
Copy link

https://github.com/InstantID/InstantID
This one has a similar function, and the results are amazing
image
image

@sdbds
Copy link
Collaborator

sdbds commented Jan 23, 2024

After testing,
InstantID>ipadapter face IDv2>PhotoMaker
https://github.com/InstantID/InstantID

image

InstantID specially train a controlnetxl for control space position in here
https://huggingface.co/InstantX/InstantID

@hben35096
Copy link

经过测试,InstantID>ipadapter face IDv2>PhotoMaker

So, would you consider adding InstantID to ControlNet? :D

@haofanwang
Copy link

It would be very appreciated if you can add InstantID.

@anilken
Copy link

anilken commented Jan 24, 2024

We would be grateful for support InstantID

@lhucklen
Copy link

lhucklen commented Jan 24, 2024

I fourth this! I would like to try out both
@huchenlei

@Paper99
Copy link

Paper99 commented Jan 29, 2024

@EriIaz
Copy link

EriIaz commented Jan 29, 2024

Is PhotoMaker implementation still being developed?
I've got a tad better results with it and SDXL in Comfy as opposed to FaceID, assuming multiple references, and I can't run InstantID in A1111's UI at adequate speed because the current implementation only takes effect with a secondary ControlNet, which is insanely VRAM hungry. I am pretty sure InstantID can be optimized in this regard, making ControlNet optional and possibly, converting it into ControlLORA. But I assume it's a challenge, any low hanging fruit would be already implemented otherwise. A PhotoMaker implementation would provide a decent SDXL-compatible alternative for people with 12GB and even 10GB GPUs.

@huchenlei
Copy link
Collaborator Author

@kigy1
Copy link

kigy1 commented May 17, 2024

Photomaker supported in https://github.com/lllyasviel/stable-diffusion-webui-forge

thanks for your work, can you make it work in automatic1111 ?

@mykeehu
Copy link

mykeehu commented Jun 10, 2024

Any news for Auto1111?
AssertionError: ip-adapter-photomaker-v1-sdxl not found in ipadapter presets. Please try manually pick preprocessor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests